Recipe for .gitignore update

[jonesbusy]

What feature do you want to see added?

Right now the .gitignore is just added when missing.

We need some logic to merge with entries from archetype

Upstream changes

None

Are you interested in contributing this feature?

No response

[nagu165]

Hello sir,
If i may ask for some more context regarding this

What i understood : Creating an openrewrite recipe to merge the entries from a .gitignore file in an archetype with an existing .gitignore file
Am i right?

[jonesbusy]

Yes if the file is missing it's created (already the case).

But if the file already exist entries must be merged with the .gitignore entries from archetype to ensure user defined entries are not erased.

It's possible that JGit provide some utilities to know if some entries are overlapping.

[jonesbusy]

https://github.com/jenkinsci/archetypes/blob/master/common-files%2Fgitignore

[nagu165]

Understood sir, I'm assuming it's similar to what i am working on with pr#560 so can i work on this simultaneously along with it.

Thank you.

[nagu165]

Yes if the file is missing it's created (already the case).

But if the file already exist entries must be merged with the .gitignore entries from archetype to ensure user defined entries are not erased.

It's possible that JGit provide some utilities to know if some entries are overlapping.

https://archive.eclipse.org/jgit/site/6.3.0.202209071007-r/org.eclipse.jgit/apidocs/org.eclipse.jgit/org/eclipse/jgit/ignore/FastIgnoreRule.html
Is this the JGit utility you were referring to? I think this might work.

[jonesbusy]

Yea : https://github.com/eclipse-jgit/jgit/blob/master/org.eclipse.jgit/src/org/eclipse/jgit/ignore/FastIgnoreRule.java

(Just note that we are on latest version of JGit)

[nagu165]

Hello sir,
Sorry if i am wasting your time.
I've been searching for a way to write the tests for merging gitignore files but couldn't find any solid resource on it.(I did find some ways but i'm not very confident that they are correct)
Could you please share any resource that might help me.

Thank you.

[jonesbusy]

Please come with a proposal. I don't have the answer to the question

[nagu165]

I tried having 3 text blocks (1 for the gitignore that already exists, 1 for archetype file, 1 the expected result after merging ) will this work?
May i open a pr for it?