Relative path remediation completly break pom formatting

[jonesbusy]

Plugin Modernizer version

1046.v7cedb_6c8df3f

What Operating System are you using

linux

Reproduction steps

plugin-modernizer dry-run --plugins railflow-testrail --recipe UpgradeToRecommendCoreVersion

Expected Results

Just adding the relative path without much change.

Right now the result is quite catastrophic

• Empy line
• Whitespace etc...

[jonesbusy]

If not possible to fix due to parser, what about

mvn spotless:apply -Dspotless.check.skip=false "-DspotlessFiles=.*pom.xml"

after any pom remediation

If the pom is very different we will get a huge diff, but at least the pom.xml will follow best practice ?

[gounthar]

In the meantime, yes.
I will try with other parsers later on, that may fix the issue.

[jonesbusy]

Fixed by #553 and 550 that either remove condition are use standard regex to perform the update (for example java.level or parent pom). The bom is not needed because we upgrade plugin to the lowest minimum version to compile with Java 8 and then just invoke OpenRewrite.

Some recipe like AddCodeOwner will not work out of the box for outdated plugin but should rather be run from modernization recipes or cookbook #50