You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have no idea why, but when trying to translate de.wikipedia.org with German-English base it fails, and just repeats the first word for every word in the input text.
What I've tried:
Older version of bergamot-translator: no difference
Using bergamot-translator natively: works just fine (after adding a mini-batch-words: 1024 entry to the config)
Using the individual model files with the worker.js from bergamot-translator, as opposed to the .tar.gz extraction happening in this fork. If yes, then this is a bug in the WASM build of bergamot-translator?
To experience this yourself: Check out c5c308a, and apply this patch to prefer base models over tiny models:
diff --git a/extension/controller/translation/translationHelper.js b/extension/controller/translation/translationHelper.js
index e9ed0c7203faf809a923d126971a5c1fd78bc277..edb3046559905f5a3f2cec7f537c6b46d13cd7ba 100644
--- a/extension/controller/translation/translationHelper.js+++ b/extension/controller/translation/translationHelper.js@@ -233,6 +233,8 @@ class Channel {
// Prefer tiny models above non-tiny ones (right now base models don't even work properly 😅)
entries.sort((a, b) => (a.shortName.indexOf('tiny') === -1 ? 1 : 0) - (b.shortName.indexOf('tiny') === -1 ? 1 : 0));
+ entries.reverse();+
if (!entries)
throw new Error(`No model for ${from} -> ${to}`);
The text was updated successfully, but these errors were encountered:
Waiting on browsermt/marian-dev#81. If that gets fixed, this is fine. If not, we might need to drop mozilla's embedded intgemm and always use the fallback path (and then probably push a few more things to get to a reasonable speedy experience.)
This case is mentioned in the code. I don't think Mozilla intends to fix its embedded MozIntGemm, but I also don't think Mozilla intends to ship it in any release version of Firefox. So closing this for now as the only one impacted by it would be the people that are already aware of it.
I have no idea why, but when trying to translate de.wikipedia.org with German-English base it fails, and just repeats the first word for every word in the input text.
What I've tried:
mini-batch-words: 1024
entry to the config)To experience this yourself: Check out c5c308a, and apply this patch to prefer base models over tiny models:
The text was updated successfully, but these errors were encountered: