-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
margin at 1350 #57
Comments
very detailed description |
i was referring to the margin breakpoints. ocular is a bit wide on smaller screened devices. |
interesting |
so @towerofnix, should the margin breakpoint be smaller? it's currently that |
@jeffalo my monitor is something ive seen a few layouts do is go for a percentage-based look instead of static margins, allowing the breakpoint to be placed quite a bit lower before the margin becomes an obstruction; e.g. see it only really becomes a bother at the final smallest screen (150% zoom thin viewport); that could possibly be detected (and have padding removed) with worth noting that scratch uses roughly this layout:
but it also has a higher default font size than ocular, so that counters out the relatively large width of 1350. just various factors to consider when layouting! |
so if i mirroed the scratch forum's margins would that be good enough? .margined {
width: 942px;
margin-left: auto;
margin-right: auto;
} and the scratch forum doesn't do this, but it fixes margins on mobile @media only screen and (max-width: 1050px) {
.margined {
/*background-color: lightblue;*/
width: 98%;
margin-left: auto;
margin-right: auto;
}
} |
yes, i think that would work pretty well! (tested via inspect element and it looks good!) |
awesome. the only problem is when i asked people on the ocular thread, they really didn't how much space would be wasted. i wonder if i pushed this if anyone would really care that much though. |
i saw some comments there and their concerns are valid—i think its probably not too bad as is currently, and userstyles can go enough of the way to adjust things to my own preferences :P to be honest i think boosting the font size to a bigger default size (or simply not changing it from the browser default, usually 16px but possibly larger or smaller) would be just as useful, but that would probably also be worth checking in with other users about 📦 |
thanks. i don't remember why i changed the font size, i'll see if keeping it as browser default messes with anything. |
I actually thing using the same margins as Scratch would be a good idea if the layout of posts was exactly the same as Scratch's (so the left part with the profile picture would have a with of |
the margin breakpoint should start at widths lower than 1350px
The text was updated successfully, but these errors were encountered: