Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

margin at 1350 #57

Open
jeffalo opened this issue Apr 26, 2021 · 12 comments
Open

margin at 1350 #57

jeffalo opened this issue Apr 26, 2021 · 12 comments
Labels
theming this issue relates to the theme system

Comments

@jeffalo
Copy link
Owner

jeffalo commented Apr 26, 2021

the margin breakpoint should start at widths lower than 1350px

@jeffalo jeffalo added the theming this issue relates to the theme system label May 4, 2021
@CluckCluckChicken
Copy link
Contributor

very detailed description

@jeffalo
Copy link
Owner Author

jeffalo commented May 26, 2021

i was referring to the margin breakpoints. ocular is a bit wide on smaller screened devices.

@CluckCluckChicken
Copy link
Contributor

interesting

@towerofnix
Copy link

i browse basically every internet page at 120-150% resolution because my eyes suck and dear lord the margin makes it kinda hard to read forum posts lol, they take up the full width of my desktop screen:

A forum thread I've opened in Ocular, with the width so wide you have to scan your eyes across nearly the entire screen reading each text line.

@jeffalo
Copy link
Owner Author

jeffalo commented May 30, 2021

so @towerofnix, should the margin breakpoint be smaller? it's currently that 1500px for when it becomes full width. how wide is your monitor?

@towerofnix
Copy link

@jeffalo my monitor is 1920px wide, though at full-screen the CSS width is about 1272px. the trouble is that this is an apparently thin amount of space, but the width of the screen its displaying on is still, like, my entire 20 inch screen or so :P

something ive seen a few layouts do is go for a percentage-based look instead of static margins, allowing the breakpoint to be placed quite a bit lower before the margin becomes an obstruction; e.g. see margin-left: 12%; margin-right: 12% at 100%, 150%, 100% (small screen), and 150% (small screen).

it only really becomes a bother at the final smallest screen (150% zoom thin viewport); that could possibly be detected (and have padding removed) with in/cm units, though i havent played with it myself :P

worth noting that scratch uses roughly this layout:

max-width: 1350px; /* per memory, check scratch's css to be sure */
margin-left: auto;
margin-right: auto;

but it also has a higher default font size than ocular, so that counters out the relatively large width of 1350. just various factors to consider when layouting!

@jeffalo
Copy link
Owner Author

jeffalo commented Jun 1, 2021

so if i mirroed the scratch forum's margins would that be good enough?

.margined {
  width: 942px;
  margin-left: auto;
  margin-right: auto;
}

and the scratch forum doesn't do this, but it fixes margins on mobile

@media only screen and (max-width: 1050px) {
  .margined {
    /*background-color: lightblue;*/
    width: 98%;
    margin-left: auto;
    margin-right: auto;
  }
}

@towerofnix
Copy link

yes, i think that would work pretty well! (tested via inspect element and it looks good!)

@jeffalo
Copy link
Owner Author

jeffalo commented Jun 2, 2021

yes, i think that would work pretty well! (tested via inspect element and it looks good!)

awesome. the only problem is when i asked people on the ocular thread, they really didn't how much space would be wasted. i wonder if i pushed this if anyone would really care that much though.

@towerofnix
Copy link

i saw some comments there and their concerns are valid—i think its probably not too bad as is currently, and userstyles can go enough of the way to adjust things to my own preferences :P

to be honest i think boosting the font size to a bigger default size (or simply not changing it from the browser default, usually 16px but possibly larger or smaller) would be just as useful, but that would probably also be worth checking in with other users about 📦

@jeffalo
Copy link
Owner Author

jeffalo commented Jun 5, 2021

thanks. i don't remember why i changed the font size, i'll see if keeping it as browser default messes with anything.

@mxmou
Copy link
Contributor

mxmou commented Jun 21, 2021

I actually thing using the same margins as Scratch would be a good idea if the layout of posts was exactly the same as Scratch's (so the left part with the profile picture would have a with of 208px instead of 20%).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theming this issue relates to the theme system
Projects
None yet
Development

No branches or pull requests

4 participants