Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make diskusage Context Aware #49

Open
larssvensby opened this issue Jan 23, 2020 · 4 comments
Open

Make diskusage Context Aware #49

larssvensby opened this issue Jan 23, 2020 · 4 comments

Comments

@larssvensby
Copy link

We use diskusage in an Electron application and Electron is soon requiring Native Modules in the Renderer Process to be NAPI or Context Aware.

Is it possible to make diskusage Context Aware?
See electron/electron#18397 and an example https://github.com/atom/node-keytar/pull/182/files

Thanks

@jduncanator
Copy link
Owner

This looks relatively low cost, should be straightforward to add as well. I'll take a look at this over the next week, thanks!

@larssvensby
Copy link
Author

Thanks!
I also saw this blagoev@d55db9d

@aleksey-hoffman
Copy link

@jduncanator hey mate, any progress on making this context aware on NAPI? What do you think about blagoev@d55db9d ?

@xiaoxiangmoe
Copy link

@aleksey-hoffman Good Job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants