Language redirector #503

AHOHNMYC · 2020-05-14T23:03:09Z

Add simple redirector
Rename existing langs according RFC and ISO:
https://tools.ietf.org/html/rfc5646#section-2.1
~~https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes~~
https://demo.icu-project.org/icu-bin/locexp#region

Closes #496

Rename existing langs according RFC and ISO: https://tools.ietf.org/html/rfc5646#section-2.1 https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

tupaschoal

Yay, I really like this, thanks for the PR. I've left some comments, one other thing that could be changed is modifying the CONTRIBUTING.md file so that the translation step 1 points to the specific wiki page that we are now using as source for the languages.

assets/js/langRedirector.js

Co-authored-by: Tulio Leao <[email protected]>

AHOHNMYC · 2020-05-15T21:07:43Z

There were too high question_per_line level, so I decided to rewrite the code 🐈

assets/js/langRedirector.js

Nightfirecat · 2020-05-16T00:48:04Z

assets/js/langRedirector.js

+// Wrap all this to not pollute global namespace
+{
+    // Generate an array of languages from page
+    const JDM_LANGS = [...document.querySelectorAll('#language-dropdown > ul > li')].map(el => el.classList[0]);


Define this as a global constant via <script> block in Jekyll instead of parsing languages out of a query selector of language dropdown links.

Nightfirecat · 2020-05-16T00:52:11Z

assets/js/langRedirector.js

+        const link = document.querySelector(`#language-dropdown > ul > li.${lang} > a`);
+        if (link)
+            link.click();


Since our language URL is very simple, I'd rather set window.location to perform this redirection.

Suggested change

const link = document.querySelector(`#language-dropdown > ul > li.${lang} > a`);

if (link)

link.click();

if (lang) {

window.location = `${(new URL(window.location)).origin}/${lang}`;

}

Not as simple. At least, we have en that points to /:

Suggested change

const link = document.querySelector(`#language-dropdown > ul > li.${lang} > a`);

if (link)

link.click();

if (lang) {

let path = lang;

if (lang === 'en')

path = '';

location = location.origin+'/'+path;

}

AHOHNMYC · 2020-05-16T03:51:33Z

Btw, I've find great tool that seems to be more authoritative than Wikipedia: https://demo.icu-project.org/icu-bin/locexp#region
Chromium and Firefox uses ICU, so we have to use it like them :)
Link added in the first comment.

Instead of first test on all languages

tupaschoal

Can you mark the issues that you've solved as such? I think there's one pending from @Nightfirecat and my new ones.

Also do note that you need to rebase your branch as it currently has conflicts with master

tupaschoal · 2020-05-16T12:57:42Z

assets/js/langRedirector.js

+        localStorage.setItem('langRedirectionHasDone', true);
+        redirectTo(guessedTranslation());


Suggested change

localStorage.setItem('langRedirectionHasDone', true);

redirectTo(guessedTranslation());

redirectTo(guessedTranslation());

localStorage.setItem('langRedirectionHasDone', true);

I guess I'd swap the order here, it seems more legit hahah

tupaschoal · 2020-05-16T13:11:06Z

assets/js/langRedirector.js

+    function guessedTranslation() {
+        const langs = navigator.languages;
+
+        for (let i=0; i < langs.length; i++) {
+            let lang = langs[i];
+
+            // user has: 'pt-BR'
+            // we have:  'pt-BR'
+            if (JDM_LANGS.includes(lang))
+                return lang;
+
+            // user has: 'ru-RU'
+            // we have:  'ru'
+            lang = lang.slice(0,2);
+            if (JDM_LANGS.includes(lang))
+                return lang;
+
+            // user has: 'pt-AO' or 'pt'
+            // we have:  'pt-BR'
+            for (let j=0; j < JDM_LANGS.length; j++) {
+                let jdm_lang = JDM_LANGS[j];
+                if (jdm_lang.slice(0,2) === lang)
+                    return jdm_lang;
+            }
+        }
+
+        return null;
+    }


Suggested change

function guessedTranslation() {

const langs = navigator.languages;

for (let i=0; i < langs.length; i++) {

let lang = langs[i];

// user has: 'pt-BR'

// we have: 'pt-BR'

if (JDM_LANGS.includes(lang))

return lang;

// user has: 'ru-RU'

// we have: 'ru'

lang = lang.slice(0,2);

if (JDM_LANGS.includes(lang))

return lang;

// user has: 'pt-AO' or 'pt'

// we have: 'pt-BR'

for (let j=0; j < JDM_LANGS.length; j++) {

let jdm_lang = JDM_LANGS[j];

if (jdm_lang.slice(0,2) === lang)

return jdm_lang;

}

}

return null;

}

function exactLangMatch(lang) {

// user has: 'pt-BR'

// we have: 'pt-BR'

return (JDM_LANGS.includes(lang) ? lang : null);

}

function partialLangMatch(lang) {

// user has: 'ru-RU'

// we have: 'ru'

lang = lang.slice(0,2);

return exactLangMatch(lang);

}

function roughLangMatch(lang) {

// user has: 'pt-AO' or 'pt'

// we have: 'pt-BR'

for (let j=0; j < JDM_LANGS.length; j++) {

let jdm_lang = JDM_LANGS[j];

if (jdm_lang.slice(0,2) === lang)

return jdm_lang;

}

return null;

}

function guessedTranslation() {

const langs = navigator.languages;

for (let i=0; i < langs.length; i++) {

let lang = langs[i];

let exactLang = exactLangMatch(lang);

if (exactLang !== null)

return exactLang;

let partialLang = partialLangMatch(lang);

if (partialLang !== null)

return partialLang;

let roughLang = roughLangMatch(lang.slice(0,2));

if (roughLang !== null)

return roughLang;

}

return null;

}

I'd suggest extracting each of the matches into a function. For the second one we can actually reuse the first and it moves the comments there. I don't particularly like all the if !== null, but I think overall it's clearer. Let me know what you guys think.

tupaschoal · 2020-05-16T13:25:37Z

Another pending past issue:

one other thing that could be changed is modifying the CONTRIBUTING.md file so that the translation step 1 points to the specific wiki page that we are now using as source for the languages.

tupaschoal · 2020-06-05T20:01:56Z

Hello @AHOHNMYC , do you intend to continue working on this?

No pressure, just want to know to see how we can move forward or help you :)

tupaschoal · 2021-03-23T00:23:37Z

Hello @AHOHNMYC ,

I'm going to close this soon if you don't intend to continue, to clean up the PRs. Feel free to reopen if you want to resume it, it's a very nice addition!

Thanks

AHOHNMYC added 3 commits May 15, 2020 01:48

Add simple redirector

8aaca25

Rename existing langs according RFC and ISO: https://tools.ietf.org/html/rfc5646#section-2.1 https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

Fix after renaming and including new redirector script

84d0f77

Fix trailing space

222b4e8

tupaschoal reviewed May 15, 2020

View reviewed changes

assets/js/langRedirector.js Outdated Show resolved Hide resolved

assets/js/langRedirector.js Outdated Show resolved Hide resolved

assets/js/langRedirector.js Outdated Show resolved Hide resolved

assets/js/langRedirector.js Outdated Show resolved Hide resolved

AHOHNMYC and others added 3 commits May 15, 2020 08:06

Fix English in comment

1fcc422

Co-authored-by: Tulio Leao <[email protected]>

Rewrite redirector to simplify it

c6f8b59

Replace tab with space

4106fa7

Nightfirecat requested changes May 16, 2020

View reviewed changes

Rewrite language-guessing heuristics

49c47e9

Do all the tests firstly on first languages

b9fae2e

Instead of first test on all languages

tupaschoal reviewed May 16, 2020

View reviewed changes

tupaschoal closed this Aug 21, 2021

tupaschoal mentioned this pull request Aug 21, 2021

Auto-redirect to localized version #496

Open

Foggalong mentioned this pull request Aug 30, 2021

Inconsistent ISO Codes #941

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Language redirector #503

Language redirector #503

AHOHNMYC commented May 14, 2020 •

edited

Loading

tupaschoal left a comment

AHOHNMYC commented May 15, 2020

Nightfirecat May 16, 2020

Nightfirecat May 16, 2020

AHOHNMYC May 16, 2020

AHOHNMYC commented May 16, 2020 •

edited

Loading

tupaschoal left a comment

tupaschoal May 16, 2020

tupaschoal May 16, 2020

tupaschoal commented May 16, 2020

tupaschoal commented Jun 5, 2020

tupaschoal commented Mar 23, 2021

-        const link = document.querySelector(`#language-dropdown > ul > li.${lang} > a`);
-        if (link)
-            link.click();
+        if (lang) {
+            let path = lang;
+            if (lang === 'en')
+                path = '';
+            location = location.origin+'/'+path;
+        }

		localStorage.setItem('langRedirectionHasDone', true);
		redirectTo(guessedTranslation());

Language redirector #503

Language redirector #503

Conversation

AHOHNMYC commented May 14, 2020 • edited Loading

tupaschoal left a comment

Choose a reason for hiding this comment

AHOHNMYC commented May 15, 2020

Nightfirecat May 16, 2020

Choose a reason for hiding this comment

Nightfirecat May 16, 2020

Choose a reason for hiding this comment

AHOHNMYC May 16, 2020

Choose a reason for hiding this comment

AHOHNMYC commented May 16, 2020 • edited Loading

tupaschoal left a comment

Choose a reason for hiding this comment

tupaschoal May 16, 2020

Choose a reason for hiding this comment

tupaschoal May 16, 2020

Choose a reason for hiding this comment

tupaschoal commented May 16, 2020

tupaschoal commented Jun 5, 2020

tupaschoal commented Mar 23, 2021

AHOHNMYC commented May 14, 2020 •

edited

Loading

AHOHNMYC commented May 16, 2020 •

edited

Loading