Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand applicability of Step1 to a broader range of identifiers #36

Open
greenetarget opened this issue May 6, 2020 · 2 comments
Open

Comments

@greenetarget
Copy link

I downloaded a xml- model constructed by others, the file is using SEED ID for metabolite and when I ran DNA/RNA/protein_coefficients, it gives:
AttributeError: DictList has no attribute or entry atp_c
AttributeError: 'dict' object has no attribute 'iteritems'

Any suggestion?... Thank you!

@jclachance
Copy link
Owner

Yes, BOFdat is implemented for BiGG identifiers. The SEED identifiers in your model will therefore not be recognized.

It was previously suggested to add a conversion feature so that other identifiers could be used, which would indeed greatly improve the applicability of the package. I am changing the name of that issue to refer specifically to this issue.

@jclachance jclachance changed the title Step 1 AttributeError Expand applicability of Step1 to a broader range of identifiers May 6, 2020
@hariszaf
Copy link

hariszaf commented Nov 3, 2022

Hi @jclachance .
It seems that you had merged @EBosi PR in the main branch but the conversion_table is not there..
I thought of letting you know as it 's a bit weird to me.
As changes came through years, I have a revised version of his script if you d be interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants