Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get creation of flat buffer off of critical async path #156

Open
TylerADavis opened this issue Aug 22, 2017 · 0 comments
Open

Get creation of flat buffer off of critical async path #156

TylerADavis opened this issue Aug 22, 2017 · 0 comments

Comments

@TylerADavis
Copy link
Collaborator

Currently the creation of a flat buffer takes a non trivial amount of time, slowing down asynchronous operations. It may be beneficial to move the burden for creating flat buffers onto one of the worker threads.

A few approaches:

  1. Reuse flatbuffers for write operations, this is done in Speed improvements #90
  2. Have sender thread responsible for creating flat buffers
  3. Create a fourth thread that solely creates flat buffers, and then places them in send queue (seems like a bad idea)

@jcarreira let me know what you think. Additionally, were all flat buffers taking a significant amount of time to create, or just the flat buffers for write operations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant