-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backlogged doc updates #247
Conversation
e389078
to
de31364
Compare
de31364
to
0f86af1
Compare
|
||
npm install | ||
npm run build | ||
pip install -e . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe pip install -e
also does the npm build automatically. Is that not correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we had someone ask recently why sphinx failed to find the static bundles when it was using an editable install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the issue is that pip install -e .
no longer runs the develop
command, which is what we were relying on in setup.py to do the nodejs build. It looks like there is a new mechanism that can be used to handle editable builds, but it is not clear to me exactly how to use it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't mind the way it works now. It cuts down on the initial editable install time significantly.
Although, I do understand the convenience for newcomers not having to remember the npm build step. Should this become a separate issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue. You don't need to re-run pip install -e .
that often -- that is, after all, the whole point of an editable install. So I think it is definitely desirable for it to just work by default.
Thanks! |
also duplicate annotation for a repeated code annotation
I added a MyST example doc to satisfy #162. The MyST example doc is a bit raw, but it is meant to |
8f71de4
to
c62da57
Compare
c62da57
to
ff1fc6e
Compare
I think our existing |
I had the same thought a while ago: #162 (comment). But that was more geared toward converting rST to MyST on-the-fly and rendering both with the appropriate parsers. |
I think the |
Okay, sounds reasonable. |
Some docs updates that have accumulated.
Also (as part of the suggestions from #242 ) the hard-coded pytest CLI options have been moved from pyproject.toml to nox_file.py
resolves #162
resolves #190
resolves #234
resolves #242