Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogen iat, the Issue At key #2

Open
rpcme opened this issue Apr 23, 2015 · 3 comments
Open

autogen iat, the Issue At key #2

rpcme opened this issue Apr 23, 2015 · 3 comments

Comments

@rpcme
Copy link

rpcme commented Apr 23, 2015

right now we have nbf and exp. some providers require iat.

It would be nice to auto generate iat and compute exp based on the threshold, i.e. pass in '3600' and generate the values.

otherwise, all subclasses will need to compute it on their own, add Time::HiRes as a dep, etc.

if you would like me to try it on a branch to see how it would look, please let me know.

@jberger
Copy link
Owner

jberger commented Apr 23, 2015

the difficulty, sad as it is, is testing. With only one hash key by default, I know the hash ordering. With two, (ie if iat and some test data) were include now I don't have known hash ordering. I suppose we could simply test with iat. Perhaps an attribute to which enables automatic inclusion of iat?

@rpcme
Copy link
Author

rpcme commented Apr 23, 2015

Perhaps. My main concern is I don’t want to upend your stuff right now.

What we can do is : if I can get it “to work” in my new module, we can pull it up higher in the class hierarchy. If we find it’s too specific or can’t be generalized, it stays in the subclass.

On Apr 23, 2015, at 2:31 PM, Joel Berger [email protected] wrote:

the difficulty, sad as it is, is testing. With only one hash key by default, I know the hash ordering. With two, (ie if iat and some test data) were include now I don't have known hash ordering. I suppose we could simply test with iat. Perhaps an attribute to which enables automatic inclusion of iat?


Reply to this email directly or view it on GitHub #2 (comment).

@jberger
Copy link
Owner

jberger commented Apr 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants