-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autogen iat, the Issue At key #2
Comments
the difficulty, sad as it is, is testing. With only one hash key by default, I know the hash ordering. With two, (ie if iat and some test data) were include now I don't have known hash ordering. I suppose we could simply test with iat. Perhaps an attribute to which enables automatic inclusion of iat? |
Perhaps. My main concern is I don’t want to upend your stuff right now. What we can do is : if I can get it “to work” in my new module, we can pull it up higher in the class hierarchy. If we find it’s too specific or can’t be generalized, it stays in the subclass.
|
how does https://github.com/jberger/Mojo-JWT/compare/set_iat look? |
right now we have nbf and exp. some providers require iat.
It would be nice to auto generate iat and compute exp based on the threshold, i.e. pass in '3600' and generate the values.
otherwise, all subclasses will need to compute it on their own, add Time::HiRes as a dep, etc.
if you would like me to try it on a branch to see how it would look, please let me know.
The text was updated successfully, but these errors were encountered: