refactor: Separated JDK management code into its own module #1874
Conversation
quintesse
force-pushed
the
jdkman_lib
branch
from
afc114d
to
f57b1c6
Compare
quintesse
changed the title
| private static JdkManager jdkManager = null; | ||
|
|
||
| @Nonnull | ||
| public static JdkManager jdkManager() { |
There was a problem hiding this comment.
we seem to call this in many places - but how is going to take into affect jbang provided config of i.e. providers?
There was a problem hiding this comment.
Right now the idea is that the config gets used exactly in that file you're referencing. So the builder will use the config to initialize the jdk manager, including the providers. The jdk manager itself is then completely agnostic where its configuration comes from.
There was a problem hiding this comment.
ok so in jbang cli we would not call jdkmanger() but have our own instance configured from jbang config?
There was a problem hiding this comment.
Well, this JavaUtil class is in the jbang CLI, so this code here is exactly where that instance using jbang config is created.
There was a problem hiding this comment.
NB: If you look a bit lower in the createProvider() method you see it references config, which is the jbang config. The missing part I mentioned in our chat is exactly that: tying together the config with the instance creation :-)
quintesse
force-pushed
the
jdkman_lib
branch
from
f57b1c6
to
8c7ba7e
Compare
quintesse
force-pushed
the
jdkman_lib
branch
from
8c7ba7e
to
4489268
Compare
Fixes #1857