Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 2.7 #20

Closed
jayvdb opened this issue Feb 26, 2020 · 1 comment
Closed

Python 2.7 #20

jayvdb opened this issue Feb 26, 2020 · 1 comment
Assignees
@jayvdb

Comments

@jayvdb
Copy link
Owner

jayvdb commented Feb 26, 2020

Python 2.7 should still be achievable
jayvdb added a commit that referenced this issue Feb 26, 2020
@jayvdb
_rules: Fix Python 2.7 SyntaxError
80e5be4 
Fixes #20
jayvdb added a commit that referenced this issue Feb 26, 2020
@jayvdb
_rules: Fix Python 2.7 SyntaxError
588eacf 
Fixes #20
jayvdb added a commit that referenced this issue Feb 26, 2020
@jayvdb
_rules: Fix Python 2.7 SyntaxError
b2a8862 
Related to #20
@jayvdb
Copy link
Owner Author

jayvdb commented Feb 26, 2020

https://github.com/EFForg/https-everywhere/tree/master/test/rules/src/https_everywhere_checker and https://github.com/google/sre_yield are not Python 2 compatible. As a result, rule analysis and running the upstream tests wont be possible on Python 2.

#22 is a way to get the testing fully functional on Python 2.

jayvdb added a commit that referenced this issue Feb 26, 2020
@jayvdb
_fetch: Python 2.7 gzip
4d97cd7 
Related to #20
jayvdb added a commit that referenced this issue Feb 26, 2020
@jayvdb
Add Python 2 support
442b99c 
Force `str` to be `unicode`.

Related to #20
@jayvdb jayvdb closed this as completed in 0acaf27 Feb 26, 2020
@jayvdb jayvdb self-assigned this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayvdb jayvdb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayvdb