Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like theres a subs issue (and I don't know how to fix it) #46

Open
adracamas opened this issue Mar 22, 2018 · 2 comments
Open

Looks like theres a subs issue (and I don't know how to fix it) #46

adracamas opened this issue Mar 22, 2018 · 2 comments

Comments

@adracamas
Copy link

adracamas commented Mar 22, 2018

Might be something new they added.. maybe something to break the program.. None the less you lose all the data from cleanup because it doesn't seem to bypass the error and make the MKV

Using CrunchyRoll Downloader Toolkit DX v0.98b and it seems to effect Boruto
http://www.crunchyroll.com/boruto-naruto-next-generations/episode-1-boruto-uzumaki-732523

`Attempting to decrypt subtitles...
Success! Subtitles decrypted.
Attempting to decrypt subtitles...
Success! Subtitles decrypted.
Attempting to decrypt subtitles...
Success! Subtitles decrypted.
Attempting to decrypt subtitles...
Success! Subtitles decrypted.
Attempting to decrypt subtitles...
Success! Subtitles decrypted.
Attempting to decrypt subtitles...
Success! Subtitles decrypted.
Attempting to decrypt subtitles...
Success! Subtitles decrypted.
Attempting to decrypt subtitles...
Success! Subtitles decrypted.
Starting mkv merge
mkvmerge v10.0.0 ('To Drown In You') 32bit
Error: '[Russkii]' is neither a valid ISO639-2 nor a valid ISO639-1 code. See 'mkvmerge --list-languages' for a list of all languages and their respective ISO639-2 codes.
Merge process complete

Starting Final Cleanup
Cleanup Complete`

@adracamas
Copy link
Author

Tested a work-a-round. Doesn't FIX the issue but makes them downloadable. Just leaving this for anyone that might get the same issue.

Settings.ini has a setting near the bottom for onlymainsub=False changing to True fixes the issue but will only leave you with the subtitle of whatever you state in language =.

@insanedude63
Copy link
Contributor

insanedude63 commented Mar 29, 2018

So, the problem here is that it seems Cruchyroll has added support for Russian subtitles since the last time this program was modified.
A simple fix is to add support for it in the ultimate.py located in the crunchyroll-xml-decoder folder. Around line 112 there will be a whole bunch of entries like "sub_id3 = [word.replace('[English (US)]','eng') for word in sub_id3]" just add the Russian entry like so
"sub_id3 = [word.replace('[Russkii]','rus') for word in sub_id3]"
and also in the sub_id5 section too like so
"sub_id5 = [word.replace('[Russkii]','rus') for word in sub_id5]"
Before you close it, remember to add Russian to the list of languages around line 160 like so
" , u'Russian': 'rus' "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants