-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offcanvas Push Menu not scrolling when items expand #348
Comments
Experiencing the same issue as well, reverted back to v3.1.2 until issue has been resolved. |
@shpuntj Does v3.1.2 not have this issue? |
@ReaVerHC version 3.1.2 does not have the issue. |
the problem is that overflow-y is set to auto for navmenu-fixed-left, but not for navmenu-fixed-right. |
@cqcsobreyra Thanks for the reply, is there a chance you can drop it in a fiddle or something please? I'm a bit intermediate with regards to editing the jquery/javascript. |
We have the same issue as well (demo page and custom implementation). Tested on Android 5.1, Safari iOS 7 iPhone. Even explicitly forcing overflow-y:scroll !important; doesn't help. This one is difficult to debug because it works on every test case we've tried on desktop. |
great plugin.. have the same issue in https://jasny.github.io/bootstrap/examples/navmenu-push/ .. cant scroll from chrome and firefox (android) in landscape.. |
@ReaVerHC if you just specify v3.1.2 exactly (in your For 3.1.3, I was able to scroll the menu by wrapping the contents of the navmenu in a container, e.g. :
I tested the above solution on desktop (chrome, ff, safari) and it works, but unfortunately it's still broken for mobile, so i'm working around it by collapsing my sidebar content under header categories until it's fixed. |
I have since reverted back to v3.1.2 and it does indeed fix the problem of the mobile sidebar not scrolling. Unfortunately it created another problem for me. Now every time I close the off-canvas sidebar and go back to the page, I can't scroll up or down on the page anymore. If I go to a new page, I can scroll everywhere, but as soon as I open the off-canvas nav then close it my screen allows no scrolling from whatever part of the website I was last on. Anyone heard of this issue? |
Dropping to 3.1.2 fixed this for me as well. http://cdnjs.com/libraries/jasny-bootstrap/3.1.2 Thanks for the help. |
Dropping to 3.1.2 fixed this for me too |
Dropping back to 3.1.2 fixes the long menu scroll issue. On 3.1.2, if you keep dragging the offcanvas menu when it reaches the top or the bottom of the viewport, you will end up scrolling the "body" which is supposed to be overflow hidden. 3.1.2 functions on touch devices while 3.1.3 does not. Both works great on desktop browsers. |
I've been implementing the offcanvas navmenu for a client project this week, and I am in agreement with @julesman that this brilliant and wonderful project is rendered useless by these bugs. I also noticed that the issues appear in the v3.1.3 demo. I did get the menu scroll working (I'm using
Two bugs remain:
|
Even with the suggestions in this issue, scrolling the menu on Chrome (Android) still doesn't work. I'm using 3.1.3. |
This worked for me, tested on iPhone 6: In the 3.1.3 javascript file change:
to
Maybe there are some CSS changes needed too, Good luck! |
Sorry. It looks like this is now being tracked under a different issue number: #421 |
Hey mate, thanks for an awesome plugin.
I am trying to implement the push menu in a project but noticed that when you expand the offcanvas menu items that you cannot scroll vertically if the menu gets longer than your view port. It's as if the menu is "locked" from scrolling vertically. I tried it on your example page and it does the same as in my project: https://jasny.github.io/bootstrap/examples/navmenu-push/ . I tested it on the iPhone 4s.
I tried to see if someone else had this issue but can't find anything so I'm not sure if you are aware of this.
Thanks again
The text was updated successfully, but these errors were encountered: