Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of React Hooks #37

Open
jaredpetersen opened this issue Dec 16, 2019 · 1 comment
Open

Take advantage of React Hooks #37

jaredpetersen opened this issue Dec 16, 2019 · 1 comment

Comments

@jaredpetersen
Copy link
Owner

React Hooks didn't exist when codeprinter was last overhauled. Look into how it may benefit the project and make the necessary changes.

@zkarmi
Copy link

zkarmi commented Oct 13, 2020

Hi there,
I came across codeprinter when I was trying to print some code solutions out. I found the app helpful, and since I've never contributed to an online open source app before, I thought I'd run through this issue. Essentially all I did was convert the class components to functional components and implement the useState() hook. Nothing too fancy. I didn't find any opportunities for useEffect() or useRef(), for example.

I've never pushed a PR for a project I wasn't part of before, but I'm happy to do so if there's any interest. The code seems to still work just fine, and all the tests are still passing. Let me know, and thanks again for building this!

Best regards,
Ziv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants