Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.14.0 rpts2 cache issue with Yarn workspaces #888

Closed
jaredpalmer opened this issue Sep 24, 2020 · 4 comments · Fixed by #896
Closed

v0.14.0 rpts2 cache issue with Yarn workspaces #888

jaredpalmer opened this issue Sep 24, 2020 · 4 comments · Fixed by #896
Assignees
@agilgur5
Labels
kind: bug Something isn't working scope: upstream Issue in upstream dependency solution: duplicate This issue or pull request already exists solution: workaround available There is a workaround available for this issue topic: rollup-plugin-typescript2 Issues and PRs relating to rpts2

Comments

@jaredpalmer
Copy link
Owner

Current Behavior

TSDX isn't building when used with yarn workspaces. Seems like it may be a rollup-plugin-typescript-2 cache issue?

(typescript) Error: ENOENT: no such file or directory, rename '/Users/jared/workspace/github/jaredpalmer/formik-actual/packages/formik/node_modules/.cache/rollup-plugin-typescript2/rpt2_48f7284bed271946d808c741a74a6d872af7a18e/code/cache_' -> '/Users/jared/workspace/github/jaredpalmer/formik-actual/packages/formik/node_modules/.cache/rollup-plugin-typescript2/rpt2_48f7284bed271946d808c741a74a6d872af7a18e/code/cache'
Error: ENOENT: no such file or directory, rename '/Users/jared/workspace/github/jaredpalmer/formik-actual/packages/formik/node_modules/.cache/rollup-plugin-typescript2/rpt2_48f7284bed271946d808c741a74a6d872af7a18e/code/cache_' -> '/Users/jared/workspace/github/jaredpalmer/formik-actual/packages/formik/node_modules/.cache/rollup-plugin-typescript2/rpt2_48f7284bed271946d808c741a74a6d872af7a18e/code/cache'
    at Object.renameSync (fs.js:643:3)
    at RollingCache.roll (/Users/jared/workspace/github/jaredpalmer/formik-actual/node_modules/tsdx/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:24003:12)
    at TsCache.done (/Users/jared/workspace/github/jaredpalmer/formik-actual/node_modules/tsdx/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:24845:24)
    at Object._ongenerate (/Users/jared/workspace/github/jaredpalmer/formik-actual/node_modules/tsdx/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:29098:21)
    at Object.generateBundle (/Users/jared/workspace/github/jaredpalmer/formik-actual/node_modules/tsdx/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:29076:18)
    at /Users/jared/workspace/github/jaredpalmer/formik-actual/node_modules/rollup/dist/shared/node-entry.js:13117:25
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

Expected behavior

TSDX 14 works with yarn workspaces

Suggested solution(s)

Additional context

Your environment

  System:
    OS: macOS 10.15.5
    CPU: (8) x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
    Memory: 2.11 GB / 16.00 GB
    Shell: 3.0.2 - /usr/local/bin/fish
  Binaries:
    Node: 12.14.1 - ~/n/bin/node
    Yarn: 1.22.4 - ~/.yarn/bin/yarn
    npm: 6.13.4 - ~/n/bin/npm
  Browsers:
    Chrome: 85.0.4183.121
    Chrome Canary: 87.0.4273.0
    Firefox: 71.0
    Firefox Developer Edition: 67.0
    Firefox Nightly: 58.0a1
    Safari: 13.1.1
    Safari Technology Preview: 14.0
  npmGlobalPackages:
    tsdx: 0.14.0
    typescript: 3.8.3
@jaredpalmer jaredpalmer added kind: bug Something isn't working kind: regression labels Sep 24, 2020
@jaredpalmer
Copy link
Owner Author

Have no idea why that happened. Nuked node modules and now it seems to be okay.

@agilgur5 agilgur5 added kind: support Asking for support with something or a specific use case solution: can't repro An attempt to reproduce has been tried and failed and removed kind: bug Something isn't working kind: regression labels Sep 25, 2020
@agilgur5 agilgur5 changed the title v0.14 No longer supports yarn workspaces v0.14 No longer supports yarn workspaces -- rpts2 cache issue Sep 25, 2020
@agilgur5 agilgur5 changed the title v0.14 No longer supports yarn workspaces -- rpts2 cache issue v0.14.0 rpts2 cache issue Sep 25, 2020
@agilgur5 agilgur5 added the scope: upstream Issue in upstream dependency label Sep 29, 2020
@agilgur5
Copy link
Collaborator

Looks like this is a cache bug upstream that was recently fixed: ezolenko/rollup-plugin-typescript2#243

@agilgur5 agilgur5 added the solution: workaround available There is a workaround available for this issue label Oct 1, 2020
@agilgur5 agilgur5 mentioned this issue Oct 1, 2020
Closed
@agilgur5 agilgur5 changed the title v0.14.0 rpts2 cache issue v0.14.0 rpts2 cache issue with Yarn workspaces Oct 1, 2020
tanem added a commit to tanem/tsdx that referenced this issue Oct 6, 2020
@tanem
fix: update rollup-plugin-typescript2 to fix build issue
f4eb488 
Brings in ezolenko/rollup-plugin-typescript2#243 in order to fix jaredpalmer#888
and jaredpalmer#892.
@agilgur5 agilgur5 linked a pull request Oct 6, 2020 that will close this issue
fix/deps: upgrade rollup-plugin-typescript2 to fix cache issue #896
Merged
@tanem tanem mentioned this issue Oct 6, 2020
Merged
This was referenced Oct 7, 2020
Merged
Closed
Closed
@agilgur5 agilgur5 added solution: duplicate This issue or pull request already exists kind: bug Something isn't working and removed kind: support Asking for support with something or a specific use case solution: can't repro An attempt to reproduce has been tried and failed labels Oct 12, 2020
@agilgur5
Copy link
Collaborator

Gonna reverse mark this as duplicate of #892 since that now has more investigations

@agilgur5
Copy link
Collaborator

This has been fixed with #896 / ezolenko/rollup-plugin-typescript2#243 and just released in v0.14.1.

@agilgur5 agilgur5 added the topic: rollup-plugin-typescript2 Issues and PRs relating to rpts2 label Nov 1, 2020
@agilgur5 agilgur5 mentioned this issue Jun 8, 2022
Closed
Repository owner locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@agilgur5 agilgur5

Labels
kind: bug Something isn't working scope: upstream Issue in upstream dependency solution: duplicate This issue or pull request already exists solution: workaround available There is a workaround available for this issue topic: rollup-plugin-typescript2 Issues and PRs relating to rpts2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/deps: upgrade rollup-plugin-typescript2 to fix cache issue tanem/tsdx
2 participants
@jaredpalmer @agilgur5