Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support husky v6 #1006

Open
morenyang opened this issue Apr 10, 2021 · 1 comment · May be fixed by #1009
Open

Support husky v6 #1006

morenyang opened this issue Apr 10, 2021 · 1 comment · May be fixed by #1009

Comments

@morenyang
Copy link

Current Behavior

Currently, in tsdx, the configuration of husky uses v4 style. But since husky stores its configuration in .husky directory, the existing configurations are no longer working.

https://typicode.github.io/husky/#/?id=migrate-from-v4-to-v6

Expected behavior

husky works, and be able to run git hooks

Suggested solution(s)

migrate the configurations to support husky v6

Additional context

Your environment

  System:
    OS: Linux 5.4 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
    Memory: 9.38 GB / 12.17 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.16.1/bin/yarn
    npm: 7.9.0 - ~/.nvm/versions/node/v14.16.1/bin/npm
@agilgur5
Copy link
Collaborator

Thanks for bringing this up. It looks like Husky v6 is back to Open Source, so there aren't concerns about incorporating it into TSDX as there were with v5.
Seems like there might be some gotchas on the upgrade path though. The not installed by default change should at least partially enable an existing feature request (need to find the issue #, on phone) as well

@morenyang morenyang linked a pull request Apr 11, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support husky v6 morenyang/tsdx
2 participants
@agilgur5 @morenyang