From 49a352131ab879ffff3e39bc6f4d4fbfb05fcfd9 Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Mon, 21 Sep 2020 02:59:41 -0400 Subject: [PATCH] ci: make internal job names more consistent w/ templates' - Adding a matrix and `bahmutov/npm-install` brought the templates closer to internal, now do the inverse - Add "Checkout repo" name for checkout Action - previously had no name internally - Reorder config options for matrix to match templates - Use "Node" consistently, not "node" or "Node.js" - Also upgrade to actions/checkout@v2 since the templates have had that since their inception --- .github/workflows/nodejs.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index e716530eb..6b02c7eae 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -11,8 +11,9 @@ jobs: name: Lint & Deduplicate deps on node 10.x and ubuntu-latest steps: - - uses: actions/checkout@v1 - - name: Use Node.js 10.x + - name: Checkout repo + uses: actions/checkout@v2 + - name: Use Node 10.x uses: actions/setup-node@v1 with: node-version: 10.x @@ -27,18 +28,18 @@ jobs: run: yarn deduplicate:check test: - runs-on: ${{ matrix.os }} + name: Test on Node ${{ matrix.node }} and ${{ matrix.os }} + runs-on: ${{ matrix.os }} strategy: matrix: node: ['10.x', '12.x', '14.x'] os: [ubuntu-latest, windows-latest, macOS-latest] - name: Test on node ${{ matrix.node }} and ${{ matrix.os }} - steps: - - uses: actions/checkout@v1 - - name: Use Node.js ${{ matrix.node }} + - name: Checkout repo + uses: actions/checkout@v2 + - name: Use Node ${{ matrix.node }} uses: actions/setup-node@v1 with: node-version: ${{ matrix.node }}