Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the plugin compatible with GVim #19

Closed
t-pohl opened this issue Aug 5, 2024 · 7 comments
Closed

Make the plugin compatible with GVim #19

t-pohl opened this issue Aug 5, 2024 · 7 comments

Comments

@t-pohl
Copy link

t-pohl commented Aug 5, 2024

I really like the plugin but it seems that I can only open it from the "normal" vim. :Vivify does not seem to do anything when invoked out of Gvim.

@t-pohl t-pohl closed this as completed Aug 5, 2024
@t-pohl
Copy link
Author

t-pohl commented Aug 5, 2024

Problem was missing VIV_PORT variable

@jannis-baum
Copy link
Owner

Hello! Great to hear you like the plugin!

Problem was missing VIV_PORT variable

Could you elaborate on this? Am I reading this right that it didn't work until you explicitly set the environment variable VIV_PORT to a specific value?

@t-pohl
Copy link
Author

t-pohl commented Aug 5, 2024

Yes, you are completely right. If I do not set this variable the command hangs indefinitely.
Apart from this minor bug, great work!

@jannis-baum
Copy link
Owner

Thanks! Does this also happen when you call Vivify from the terminal, i.e. viv <file>? If so, it's probably related to jannis-baum/Vivify#157 which was just opened earlier.

@t-pohl
Copy link
Author

t-pohl commented Aug 5, 2024

It also happens on the terminal so I'm pretty sure that this is a duplicate.

@jannis-baum
Copy link
Owner

Thanks! I think I fixed it in jannis-baum/Vivify#158, if you or the OP of the other issue can confirm that that works I'll merge it and make a new release :)

@t-pohl
Copy link
Author

t-pohl commented Aug 5, 2024

Very cool, that you fixed it that fast :) Going to wait for the confirmation from the other poster and then install the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants