Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texyla is not compatible with Nette 2.2.3 #30

Open
Lkopo opened this issue Sep 17, 2014 · 2 comments
Open

Texyla is not compatible with Nette 2.2.3 #30

Lkopo opened this issue Sep 17, 2014 · 2 comments

Comments

@Lkopo
Copy link
Contributor

Lkopo commented Sep 17, 2014

After hours of finding where the problem is I found possible solution. The problem is in this condition in js/texyla.js

    if (f.onsubmit()) {
            submitnout();
    }

What doesn't work (if validation Nette JavaScript succeeds f.onsubmit() doesn't return true, only undefined if you force the get value) so it only returns false if validation fails. The correct solution should be:

    if (f.onsubmit() !== false) {
            submitnout();
    }

More in this topic on Nette forums: http://forum.nette.org/cs/20728-texyla-submit-nic-nerobi#p142301

@janmarek
Copy link
Owner

can you prepare a pull request?

@Lkopo
Copy link
Contributor Author

Lkopo commented Sep 18, 2014

#31

But I don't know what kind of change is in the end of file (I just edited condition, nothing else.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants