Realdash can bmwe46

[andreibbmwe30]

hello! tell me how to add to xml this sample is taken from the megasquirt files on the dashboard of bmw e46
if (ram5.can_bcast1 & 0x10) { // from Peter Florance
id = Engine_RPM316; //0x316 BMW E46 - engine control unit RPM is 6.42:1 ratio = outpc.rpm*6.42
val = (unsigned int)((outpc.rpm * 642UL) / 100);
data[0] = 0x00;
data[1] = 0x00;
data[2] = (unsigned char)(val & 0xff); //byte 3 = RPM, L
data[3] = (unsigned char)(val >> 8); //byte 4 = RPM, H
data[4] = 0x00;
data[5] = 0x00;
data[6] = 0x00;
data[7] = 0x00;
send_can11bit(id, data, 8);
}

if (ram5.can_bcast1 & 0x20) { // from Peter Florance
id = Engine_Temp329;// 0x329
// val = (((outpc.clt - 320) * 5) / 9)/10;
// val = (int)(((val + 48)*4)/3);
val = (1088 + (outpc.clt << 1)) / 27;
data[0] = 0x00;
data[1] = (unsigned char)val;
data[2] = 0x00;
data[3] = 0x00;
data[4] = 0x00;
data[5] = 0x00;
data[6] = 0x00;
data[7] = 0x00;
send_can11bit(id, data, 8);

[andreibbmwe30]

https://www.ms4x.net/index.php?title=Siemens_MS42_CAN_Bus#DME4_0x545

[janimm]

Added BMW Siemens MS42 CAN file:

https://github.com/janimm/RealDash-extras/tree/master/RealDash-CAN/XML-files/BMW

Give it a try.

[andreibbmwe30]

Добавлен файл BMW Siemens MS42 CAN:

https://github.com/janimm/RealDash-extras/tree/master/RealDash-CAN/XML-files/BMW

Попробуйте.
hello! thanks for the work done,there is a problem with the values constantly jumping,for example, the rpm is constantly in the red zone and the arrow jumps,the temperature shows the real but can briefly show -40 value,check constantly blinks and the throttle position is at maximum

[andreibbmwe30]

[janimm]

Take a screenshot from CAN Monitor with vehicle running at idle.

[andreibbmwe30]

Сделайте снимок экрана с CAN-монитора, когда автомобиль работает на холостом ходу.
hello! I figured out the turns, edited your file

[andreibbmwe30]

here is my option!

[andreibbmwe30]

frame id="0x316" endianess="little

[janimm]

Would appreciate pull request or attach the updated XML.

[andreibbmwe30]

<value targetId="37" offset="2" length="2"conversion="V/6.42">

[andreibbmwe30]

Был бы признателен за запрос на извлечение или прикрепление обновленного XML.

but I'm afraid that everything will change in id="0x316, since I changed "big" to "little"