Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard/ACME v2 support #110

Open
mKeRix opened this issue Mar 14, 2018 · 27 comments
Open

Wildcard/ACME v2 support #110

mKeRix opened this issue Mar 14, 2018 · 27 comments

Comments

@mKeRix
Copy link

mKeRix commented Mar 14, 2018

Let's encrypt just launched the new API with wildcard support: https://community.letsencrypt.org/t/acme-v2-and-wildcard-certificate-support-is-live/55579. Certbot 0.22.0 and above already support the new features.

Would love to see these upstream in the rancher-letsencrypt project!

@willseward
Copy link
Contributor

FWIW: go-acme/lego#457

@blackholegalaxy
Copy link

@janeczku any news on that?

@Jefnull
Copy link

Jefnull commented Mar 31, 2018

+1

@KryptionX
Copy link

If we could get this updated to support wildcards that would be extremely awesome.

@natiz
Copy link

natiz commented Apr 5, 2018

+1

1 similar comment
@nbejansen
Copy link

+1

@Chuckame
Copy link

Yes, wildcard support will awesome ! @janeczku , are u alive ?! ^^

@bearmoo-cloud-net
Copy link

+1

@B-Stefan
Copy link

go-acme/lego#457 just got merged.
Do we need to change here some code or just update the package?

@asdek
Copy link

asdek commented Jun 10, 2018

If you need to generate wildcard certificates with using ACME v2 then you can using these repos:

For using docker repo:
docker pull vxcontrol/rancher-letsencrypt

I think that making a Pull Request does not make sense ((

@Chuckame
Copy link

Chuckame commented Jun 11, 2018 via email

@blackholegalaxy
Copy link

@Chuckame because there is no vital sign from the author and repo maintainer to accept a PR?

@asdek
Copy link

asdek commented Jun 11, 2018

@Chuckame I made PR#114 to main repo. Let's see together how quickly it will be merged.

@blackholegalaxy I fully support your opinion.

@jotolo
Copy link

jotolo commented Jun 12, 2018

@asdek, Is there any catalog including your repository with the changes? I think it's a good idea to create a catalog for that, like this repository has in rancher community catalog.
Thanks anyways for the update!

@asdek
Copy link

asdek commented Jun 12, 2018

@jotolo, You can use https://github.com/vxcontrol/rancher-catalog.git repo and branch public. Or you can change field Select Image to vxcontrol/rancher-letsencrypt:v1.0.0 after deploying package from community catalog.
PS I very much hope that the author will accept the changes and this will be available in the original package.

@jotolo
Copy link

jotolo commented Jun 12, 2018

@asdek I did the second option and it worked like charm! Thank you for the PR! I hope those who have the same issue can use this solution.It's very good to have it! I hope like you the PR to be merged.
Thanks again @asdek

@bearmoo-cloud-net
Copy link

@asdek

I replace docker image to docker vxcontrol/rancher-letsencrypt. I ran the image and I'm getting this error:

6/12/2018 7:24:04 PMtime="2018-06-13T02:24:04Z" level=info msg="Using HTTP challenge: Sleeping for 120 seconds before requesting certificate"
6/12/2018 7:24:04 PMtime="2018-06-13T02:24:04Z" level=info msg="Make sure that HTTP requests for '/.well-known/acme-challenge' for all certificate domains are forwarded to port 80 of the container running this application"
6/12/2018 7:26:04 PMtime="2018-06-13T02:26:04Z" level=info msg="Trying to obtain SSL certificate (example.net,*.example.net) from Let's Encrypt Production CA"
6/12/2018 7:26:04 PMtime="2018-06-13T02:26:04Z" level=info msg="[INFO][example.net, .example.net] acme: Obtaining bundled SAN certificate"
6/12/2018 7:26:05 PMtime="2018-06-13T02:26:05Z" level=info msg="[INFO][
.example.net] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/cLnZCIg3jc_l16zduayBdwa1tK1xEDB_haUNZohrN_c"
6/12/2018 7:26:05 PMtime="2018-06-13T02:26:05Z" level=info msg="[INFO][example.net] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz/wy7n1Q5P34bpcdtkPx5TCeJM82C8dikP3uzbuW5ECwc"
6/12/2018 7:26:05 PMtime="2018-06-13T02:26:05Z" level=info msg="[INFO][example.net] acme: Authorization already valid; skipping challenge"
6/12/2018 7:26:05 PMtime="2018-06-13T02:26:05Z" level=info msg="[INFO][example.net] acme: Could not find solver for: dns-01"
6/12/2018 7:26:05 PMtime="2018-06-13T02:26:05Z" level=error msg="[acme: Error -> One or more domains had a problem:\n[example.net] [example.net] acme: Could not determine solvers\n] Error obtaining certificate: acme: Error -> One or more domains had a problem:\n[example.net] [example.net] acme: Could not determine solvers\n"

@asdek
Copy link

asdek commented Jun 13, 2018

@bearmoo-repo Which one provider you use?

@bearmoo-cloud-net
Copy link

@asdek it would be no-ip

@asdek
Copy link

asdek commented Jun 13, 2018

@bearmoo-repo I was asking about DNS provider. Because I tested on Route53 and CloudFlare, the problem was observed once with the fact that CloudFlare did not have time to update the DNS-record. I can try to incorporate some delay and define it through Environment Variable.

@bearmoo-cloud-net
Copy link

www.noip.com is my DNS provider.

@bearmoo-cloud-net
Copy link

Is it all possible to get the information that I need to add into TXT?

@asdek
Copy link

asdek commented Jun 13, 2018

www.noip.com is my DNS provider.

ok, thanks. I'll see what can do here.
If you want to add a TXT-record manually, you can use this service: https://www.sslforfree.com/

cLnZCIg3jc_l16zduayBdwa1tK1xEDB_haUNZohrN_c
wy7n1Q5P34bpcdtkPx5TCeJM82C8dikP3uzbuW5ECwc

In your log most likely these 2 values should be added within the TXT-records.

@solocommand
Copy link

@janeczku Would you be willing to make @asdek or another contributor a maintainer of this project to allow it to move forward?

@JoelESvensson
Copy link

The v1 API was just deactivated so renewals stopped working. Fortunately it seems like https://hub.docker.com/r/vxcontrol/rancher-letsencrypt works as a drop-in replacement. I recommend everyone having problems to upgrade to it instead. It being vxcontrol/rancher-letsencrypt:v1.0.0

@grabekm90
Copy link

I guess https://github.com/TrueCarry/rancher-letsencrypt/tree/acme-v2 is better updated

@bkuhl
Copy link

bkuhl commented May 2, 2020

ACME v2 - For anyone still trying to do this, check out https://gist.github.com/fridgerator/db607d268f1f99329c8f9449e89abb4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests