Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations ? #149

Open
didierm opened this issue May 13, 2020 · 6 comments
Open

Update translations ? #149

didierm opened this issue May 13, 2020 · 6 comments

Comments

@didierm
Copy link

didierm commented May 13, 2020

Being a Transifex n00b, I am not entirely sure how this works, but (referring to issue #84 and #105), are the translation files directly edited in this repo and/or sync'ed from the Tx projects https://www.transifex.com/janbar/pvrmythtv/ and/or https://www.transifex.com/teamxbmc/kodi-main ?

For example :

the erroneous Dutch string (infamous 'dt' error) :

msgstr "Verbinding met MythTV herstelt"

has been corrected 6 months ago in the teamxbmc project https://www.transifex.com/teamxbmc/kodi-main/translate/#nl_NL/pvr-mythtv/184164910 .

@janbar
Copy link
Owner

janbar commented May 13, 2020

This one: https://www.transifex.com/janbar/pvrmythtv/
The kodi-main hasn't been updated to my repo , unfortunately.
If you need a grant to translate , simply click the button to request for your(s) language(s) and I will grant you.

@didierm
Copy link
Author

didierm commented May 13, 2020

I could fix the (itching ;) ) string above, but have no idea how efficient that would be, i.e. how much the teamxbmc/kodi-main and your janbar/pvr.mythtv Tx projects are out of sync.

@janbar
Copy link
Owner

janbar commented May 13, 2020

The pvr.mythtv addon delivered with the kodi stream is this one (janbar) and translations are managed by this repo. You can check the translations from this folder: https://github.com/janbar/pvr.mythtv/tree/master/pvr.mythtv/resources/language . And then make a PR to fix it, or let me know what I have to update. Thanks

@janbar
Copy link
Owner

janbar commented May 13, 2020

I accepted your request from transifex. It will be easy now to fix the issue. You have the role of revisor, so feel free to fix all what you think better. I doesn't speak nl :-/

@didierm
Copy link
Author

didierm commented May 14, 2020

Thank you ; I fixed this specific string.

There are quite some questionable translations.
If you do not mind, I'll cherrypick/sync from teamxbmc/kodi-main those translations I consider an improvement.

For the remaining ones : do I suggest improvements to teamxbmc/kodi-main (and sync later with your repo), or is it more efficient to fix them directly in yours ?
(I've arrived here from RPMFusion, as their Fedora kodi-pvr-mythtv RPM is based on your fork).

@janbar
Copy link
Owner

janbar commented May 15, 2020

It more efficient to fix them directly in mine. The kodi-main/pvr.mythtv was dead few years ago. I claimed to link the translations from my repo, but nobody found the time to do it. Also I can only push fast forward to the kodi-pvr repo, so it is not possible to synchronize with mine. Anyway you have to only make changes here and it will be released fast.
In fact the original repo is here, but we have moved a time to centralize the contributions and finally we changed later. So this repos isn't a fork despite github show...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants