Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII characters not supported #4

Closed
CasperWA opened this issue Oct 31, 2023 · 4 comments
Closed

Non-ASCII characters not supported #4

CasperWA opened this issue Oct 31, 2023 · 4 comments

Comments

@CasperWA
Copy link

As laid out in emmo-repo/CIF-ontology#182 by @vaitkus, CIF2 now supports non-ASCII characters, which trip up the PyCIFRW parser(s).
See the referenced issue for an example.

@CasperWA
Copy link
Author

I tried using characterset="unicode" and standard="CIF2" without any luck, unfortunately.

@jamesrhester
Copy link
Owner

I've fixed this in the latest commit to the development branch, and I'll bundle up a new release once I've figured out the new python packaging approach.

The problem was that nested blocks (e.g. dictionary definitions) had default characterset setting (ascii). Plain CIF2 data files are fine.

@jamesrhester
Copy link
Owner

Please try version 4.4.6. Source distribution and linux wheels provided.

@CasperWA
Copy link
Author

CasperWA commented Nov 1, 2023

I've tested v4.4.6 and it works beautifully!
I now get unicode characters nicely in the parsed CIF and dic files.

Just to show - here is a greek kappa that has gone all the way from dic file to Turtle ontology (see κ-geometry diffractometer in the circa center of the image):
image

@CasperWA CasperWA closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants