New logger to dump a JSON file with all attributes of a Monitor & ISO dates #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for a logger that creates a JSON file with all the attributes of a Monitor. It also uses ISO 8601 for dates to make parsing easier (reference: https://xkcd.com/1179/).
In addition to the fact that the world needs another JSON file, I intend to use it in a dashboard that will allow for selective display of data.
IMPORTANT NOTE: this Logger requires
jsonpicklebut I do not know how to hint this in the code (I need to learn Poetry). If you do not intend to pull in extra dependencies please reject this PR as it won't work without.