Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout option to tests #34

Open
jamesoff opened this issue Jul 30, 2016 · 5 comments
Open

Add timeout option to tests #34

jamesoff opened this issue Jul 30, 2016 · 5 comments
Milestone

Comments

@jamesoff
Copy link
Owner

See #33. Add an option to make a test fail if it's taking too long.

@jamesoff jamesoff added this to the 1.8 milestone Jul 30, 2016
@jamesoff
Copy link
Owner Author

@jtrip
Copy link

jtrip commented Sep 23, 2016

Thanks for your work on this James.
Is this where I might want to manually adjust the timeout for now if I am currently only concerned with http?

https://github.com/jamesoff/simplemonitor/blob/master/Monitors/network.py

    def run_test(self):
        # store the current default timeout (since it's global)
        original_timeout = socket.getdefaulttimeout()
        socket.setdefaulttimeout(5)

@jamesoff
Copy link
Owner Author

Yup, that's the one.

@jamesoff
Copy link
Owner Author

#56 may be of use here as it looks like job execution can be given a timeout.

@jamesoff jamesoff modified the milestones: 1.8, 1.10 Feb 22, 2020
@jamesoff jamesoff modified the milestones: 1.10, 1.11 Jun 7, 2020
@jamesoff
Copy link
Owner Author

Should be able to handle this now that monitor evaluation is multithreaded, but I don't see a straightforward way to specify different timeouts for different monitors with it. Bumping for 1.12 while I think about it.

@jamesoff jamesoff modified the milestones: 1.11, 1.12 Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants