Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Loan with offset displays offset in periods outside of loan duration #517

Open
filip-savic opened this issue Nov 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@filip-savic
Copy link

filip-savic commented Nov 16, 2024

Describe the bug
When you have a long term loan with an offset, the offset is displayed in periods outside the loan start and end. In the summary on top, "Lent" is display with the quantifier "x 0", and the value of the offset is shown.

How to reproduce

  1. Create a long term loan of 100
  2. Add an offset of 5
  3. Go to the All spendings screen
  4. Go to previous months, when the loan was not yet started
  5. See "Lent x 0 ------ 5 €" in the period summary

Screenshots/videos
Screenshot_20241116_095757_Chrome
Screenshot_20241116_095814_Chrome
Screenshot_20241116_095843_Chrome
Screenshot_20241116_095852_Chrome

Details

  • Device: Android 14
  • App Version: 5.4.4+420

Additional notes
I see the offset as a return on the loan, so it makes sense to me to see it only in the period of the loan. It should not be displayed before the loan or after the loan end date.

It can be bigger than the loan, so it shouldn't end when the loan is collected, but when it ends on the set date.

There is also the case when the loan date is not defined, so it seems ok for the offset to be displayed in the future indefinitely.

Btw, the app is great, keep up the good work :)

Here's a minimal sql for reproduction:
cashew-2024-11-16-10-20-42-834.zip

@filip-savic filip-savic added the bug Something isn't working label Nov 16, 2024
@filip-savic filip-savic changed the title [Bug] Loan with offset displays offset in past periods [Bug] Loan with offset displays offset in periods outside of loan duration Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant