-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting "Failed to resolve plugin for module "expo-community-flipper" only on production build #25
Comments
Hey, thanks for reporting this! Can you share your |
This is my config :) thank you!
|
Everything looks right, and we didn't change any entry points going from 45-46. A few things I'd double check:
You're right 😅 this is a weird one, especially since the prebuild works... meaning that locally the plugin's working just fine. |
Hey @jakobo, referring to our conversation on Twitter, here is my Podfile, since you asked for it.
My error came out of the blue, after I've upgrade 5 packages. I reverted all of them but 2, the issue does still persist. I am suspecting expo-dev-client |
Small update: the plugin does currently not work SDK 47 |
Yeah. #38 is tracking the remaining sdk47 changes. In sdk47, it appears the expo prebuild template is no longer coming from |
For SDK46, you can use the following strategies to disable Flipper in a production build, completely excising it from your Podfile. Option 1: app.config.js (forward compatible)The easiest solution is to switch from // create a plugin configuration w/ blank options that
// is enabeld only if env is set
const expoConfigFlipper =
process.env.FLIPPER === "1"
? [
[
"expo-community-flipper",
{
// config if required
},
],
]
: [];
/** @type {import('@expo/config-types').ExpoConfig} */
const config = {
expo: {
// ...
plugins: [
// other plugins
...expoConfigFlipper,
],
},
};
module.exports = config; With this configuration, when you run prebuild / build using Option 2 (<= SDK46) Opt-Out BuildFor SDK 45/46, we do have a manual opt-out which you can try with minimal changes. This method also works for {
"expo": {
"plugins": [
[
"expo-community-flipper",
{
"ios": {
"enabled": false
}
}
]
]
}
} Both of the above solutions should be viable for SDK 46, with the config.js option being the forward-looking solution for SDK47. If you make one of these changes, please also include a redacted |
For @hirbod and others, I'm linking #42, which has a similar code smell. If you've removed the plugin completely from |
It looks like it's possible to make a fix for it: facebook/flipper#2414 (comment) I'm sorry I'm new to react native and expo so I cannot make the PR. |
Thanks @Nek-! These changes are a bit more than I'd like to introduce to the plugin, as manually controlling Flipper's pod dependencies rarely ends well. To make things worse, the linked comment tested on 0.127.0, and there's been 50 releases since then. :( Our expo integration (#41) will help with some of these issues because it'll be managed inside of the build-properties plugin; the same place where use_frameworks and other troublesome pod code is. |
Do you think that it will be compatible with the env variables in eas.json?
|
Yes, you can use the EAS env properties to control your app.config.js |
Hello, I'm getting this when I try to build for production with EAS build, even locally.
All works fine for staging or development builds.
I've spent a couple of hours, prebuild is ok but the build don't. Can't figure out why.
Expo SDK 46
eas-cli/2.1.0
expo-cli/6.0.5
Thanks
The text was updated successfully, but these errors were encountered: