-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding custom attribute/props to nodes #93
Comments
Currently there is no way to do this. May I ask what use case you have for clicking the entire node? Naturally, having something that records the click on the entire node itself would have it trigger if any child is also clicked. It would also trigger if you happen to click way away from the label, to the right, because of how the nodes fill up the remaining container space. While I would not be entirely opposed to having custom attributes, there are so many DOM nodes that make up a checkbox node that it would not be practical to have a custom property area for every one of them (e.g. |
@jakezatecky We need to allow users to tab through nodes. Any thoughts? |
@jonhill13 The ability to tab through nodes is a feature I would like to add to this component eventually (likely part of #24). I could simply add a bunch of I definitely would welcome a PR supporting tabbing through nodes, as it likely would have very little impact on other parts of the component. |
Thanks for this great library.
I am using it in a project where I need to click not only on the label of the node, but on the node itself (the
<li class="rct-node"></li>
) or at least being able to add custom attribute to each node so I can use data attribute and capture the click inside the node and use those attributes to trigger my logic.Is there a way to do this? I want to avoid creating a fork of it considering that it is constantly maintained and improved.
The text was updated successfully, but these errors were encountered: