-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidenote support #106
Comments
I actually really dig on this. I'm wondering (I'm on mobile) if it's possible to have side notes render at the end of a post. Even if it's just on mobile. But I imagine that would change the implementation drastically. I've noticed blogs include this type of thing towards the end. But it's just a suggestion. @dgnicholson this project is as much yours as it is mine. If you think it works well enough on your end then it should benefit this project 🚀 |
@jakewies Thanks for the idea! I'll have a look at that and see what's involved. Another solution I was thinking of was hiding the notes on mobile until the user clicks the superscript numeral which would then expand it inline, but I figured the target is very small and might be too easily overlooked. |
Just want to chime in with my support for this! Thanks for working on this @dgnicholson |
@dgnicholson any update? Would love to get this in the project. No pressure! |
@jakewies still on my to-do list due to Life™, but not forgotten. I dusted it off today and the functionality is close to being done, except for a counting bug and issues with the sidenote text interacting with the ToC. I'm thinking the latter issue can be addressed easily enough by showing the sidenotes inline once the width of the window starts causing overlapping with the TOC. I'd also like to investigate adding a footnote option but if it's too much work I'll add it a later. With additional style tweaks, cleanup, testing, and docs I figure I'll have a PR ready sometime in November. |
Awesome! Totes understand about Life, it took me a few months to get some time for this project this weekend. If it makes the structure of this feature easier, implementing as strictly footnotes would be pretty great too. Just a thought. |
Quick Update. After a few iterations, I've struggled to get the design work with the way the ToC is implemented. For situations where the ToC overlaps the sidenotes while scrolling I've tried various solutions like changing the background opacity of the ToC to blur out the sidenotes but that and my other solutions look kinda janky. The only thing I can think of is to have the sidenote appear inline when the ToC overlaps while scrolling down the page. I'll investigate if I can get this to work with my implementation and update either way. Note that I've also ended up enhancing the markdown footnotes--see PR: #144 |
Hi folks.
I've been playing with adding sidenote support. My current implementation puts sidenotes to the right of the text on wider screens:
On mobile, sidenotes appear inline.
They are added via shortcode. For example:
I may also add an option for margin notes which leave the number out entirely.
The bulk of the work done, but need to iron out a few things--mainly having it play nice with the ToC. If this is something that fits the project, I can add a PR when it's ready.
The text was updated successfully, but these errors were encountered: