Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Sets do not appear until saving a new one #127

Open
jaybee216 opened this issue Apr 24, 2020 · 3 comments
Open

Custom Sets do not appear until saving a new one #127

jaybee216 opened this issue Apr 24, 2020 · 3 comments

Comments

@jaybee216
Copy link

Upon first revisiting the page, you will not see any of your previously-saved custom sets, even if you have not cleared your cookies.

Once you enter a new or existing custom set and click Save, any previously-saved sets appear again.

@jaybee216
Copy link
Author

jaybee216 commented Apr 24, 2020

Inspecting setdex_custom.js and setdex_ss.js, it looks like the problem may be on line 21 of setdex_custom.js where SETDEX_CUSTOM is redefined as well as being set to the contents of the "custom" cookie.

EDIT: Looked into this further and the main reason it is not working on page load is because setdex_custom.js is being loaded earlier in the document than setdex_ss.js. We just need to move the script tag for setdex_custom.js after the others, and call reloadXYScript() after setting the SETDEX_CUSTOM value from the cookie.

@jaybee216
Copy link
Author

I have a branch with this fixed but get a 403 when trying to push it to the remote to open a PR; do I need to request permissions? @jake-white

@jaybee216
Copy link
Author

#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant