Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what is meant by "sync" #18

Closed
dmwyatt opened this issue Jul 24, 2024 · 3 comments · Fixed by #19
Closed

Clarify what is meant by "sync" #18

dmwyatt opened this issue Jul 24, 2024 · 3 comments · Fixed by #19
Labels
documentation Improvements or additions to documentation

Comments

@dmwyatt
Copy link

dmwyatt commented Jul 24, 2024

Some tools do two-way syncs with conflict resolution. Some tools sync local to remote. Others sync remote to local. Others do both without conflict resolution.

From the README it's not apparent what this tool does.

@jahwag jahwag added the documentation Improvements or additions to documentation label Jul 25, 2024
@jahwag jahwag linked a pull request Jul 25, 2024 that will close this issue
@mnieber
Copy link

mnieber commented Aug 4, 2024

First of all, this tool looks amazing, I'm looking forward to trying it!

I checked the source code to see if this tool would only upload a file if it is different from the remote one. The reason is that I don't want to spam Claude.ai with repeatedly uploading the same files.

The tool handles this correctly, which is great. But my suggestion is to explain this directly in the README (e.g. "ClaudeSync only uploads local files that are absent or different from the files in the remote project").

@jahwag
Copy link
Owner

jahwag commented Aug 4, 2024

First of all, this tool looks amazing, I'm looking forward to trying it!

I checked the source code to see if this tool would only upload a file if it is different from the remote one. The reason is that I don't want to spam Claude.ai with repeatedly uploading the same files.

The tool handles this correctly, which is great. But my suggestion is to explain this directly in the README (e.g. "ClaudeSync only uploads local files that are absent or different from the files in the remote project").

Wouldn't it have been quicker to submit a PR for your suggested change rather than commenting on a closed issue from two weeks ago?

@mnieber
Copy link

mnieber commented Aug 5, 2024

No, not quicker (and I wanted to ask if you agree this change would help). But I will create a PR then.

Also, I just synced my first project, and I'm psyched. This is amazing, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants