Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Docker Image Status? #1590

Open
4 tasks done
DaanSelen opened this issue Jun 10, 2024 · 10 comments
Open
4 tasks done

[Feature Request] Docker Image Status? #1590

DaanSelen opened this issue Jun 10, 2024 · 10 comments

Comments

@DaanSelen
Copy link

Is your feature request related to a problem? Please describe.

There are a couple of PR's for Dockerfiles and Images, what is the status of these and will there be a supported Docker image?

#1525
#1433
#1276
#771
#736
#650

They all do things a little different. So what is the vision of the Project owner?

What is your ideal solution to the problem?

A maintained Docker image.

How would this feature be used?

Uploaded to Docker Hub or any relevant Docker registry

Additional Info

No response

Checklist

@thenewlebowski
Copy link

I ended up just creating my own but would love to see one in the official repo

@Harshraj9812
Copy link

Harshraj9812 commented Jun 15, 2024

Hi @DaanSelen

We'd really like to have an official Docker image for this amazing music bot. In the meantime, you're welcome to use my repository (workflow) if you're interested in running this bot with Docker. I've been using it without any issues for the past year and would be happy to receive any improvement suggestions for my workflow/repository. If you need any configuration help, I'm here to help!

My Repo - https://github.com/Harshraj9812/HR-Bot-JMusicBot

@xFanexx
Copy link

xFanexx commented Jul 14, 2024

@klemmchr
Copy link

This is the Dockerfile I'm using

FROM openjdk:19
ENV DISCORD_TOKEN=""

WORKDIR /app

RUN curl -LJ -H 'Accept: application/octet-stream' -o JMusicBot.jar https://github.com/jagrosh/MusicBot/releases/download/0.4.2/JMusicBot-0.4.2.jar

CMD [ "java", "-Dnogui=true", "-jar", "JMusicBot.jar" ]

The version can also be passed in as an argument if needed.

@t3rminus
Copy link
Contributor

t3rminus commented Jul 19, 2024

I'm maintaining a fork that has a GitHub workflow that deploys a built image to DockerHub. If anyone wants to do the same, please feel free to build upon my work.

My fork does have some minor changes meant to make the bot easier to use on smaller, well-behaved servers, such as allowing anyone to use the -stop command if there's no DJ role set (so people can't set a huge playlist, then leave the VC and forget the bot is still playing), the option to suppress of update DMs, and removing the public bot check (I'm running one instance of the bot, but would like to also give a few trusted people access to the bot as well)... So I don't recommend using my fork directly.

https://github.com/t3rminus/MusicBot
https://hub.docker.com/repository/docker/t3rminus/jmusicbot/general

EDIT:
I do also want to credit Craumix for the original docker build script that I based mine on:
https://github.com/Craumix/jmb-container

@C0untZero
Copy link

I'd like an official image as well!

@driftywinds
Copy link

I'm maintaining a fork that has a GitHub workflow that deploys a built image to DockerHub. If anyone wants to do the same, please feel free to build upon my work.

My fork does have some minor changes meant to make the bot easier to use on smaller, well-behaved servers, such as allowing anyone to use the -stop command if there's no DJ role set (so people can't set a huge playlist, then leave the VC and forget the bot is still playing), the option to suppress of update DMs, and removing the public bot check (I'm running one instance of the bot, but would like to also give a few trusted people access to the bot as well)... So I don't recommend using my fork directly.

https://github.com/t3rminus/MusicBot https://hub.docker.com/repository/docker/t3rminus/jmusicbot/general

This exactly fits my usecase, would it be possible for you to also build arm64 versions of the image?

@t3rminus
Copy link
Contributor

t3rminus commented Aug 25, 2024

This exactly fits my usecase, would it be possible for you to also build arm64 versions of the image?

I've added arm64 builds (unfortunately I have not tested them so please let me know if they work)!

@driftywinds
Copy link

driftywinds commented Aug 25, 2024

This exactly fits my usecase, would it be possible for you to also build arm64 versions of the image?

I've added arm64 builds (unfortunately I have not tested them so please let me know if they work)!

Can confirm, it works! Thank you! I hope you keep it updated too ehe

@t3rminus
Copy link
Contributor

t3rminus commented Aug 25, 2024

Can confirm, it works! Thank you! I hope you keep it updated too ehe

Excellent! I'll try to keep it up to date, but I can't make guarantees. Open an issue on my branch if it breaks, and I'll do what I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants