[chore] Make package naming more consistent #6289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahadzaryab1
force-pushed
the
package-renames
branch
from
2eddd79 to
2c782e1
Compare
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
force-pushed
the
package-renames
branch
from
2c782e1 to
a764ebb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6289 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 356 356
Lines 20432 20432
=======================================
Hits 19656 19656
Misses 587 587
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 2, 2024
yurishkuro
approved these changes
Dec 2, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Dec 2, 2024
4 tasks
yurishkuro
pushed a commit
that referenced
this pull request
Dec 2, 2024
## Description of the changes - This is an extension of #6289 to regenerate the mocks and remove the existing mock for `storage.MetricStoreFactory` ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
plugin/metricstoplugin/metricstorestorage/metricsstoretostorage/metricstoreprometheus/metricsstoretoprometheus/metricstorestorage.MetricsFactorytostorage.MetricStoreFactoryHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test