Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracegen] Allow use of adaptive sampling #5718

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Add a new flag to tracegen to allow it to use jaegerremotesampling contrib module with OTEL SDK

How was this change tested?

  • It's not actually working at the moment, the backend does not recognize the spans without sampling tags

@yurishkuro yurishkuro requested a review from a team as a code owner July 8, 2024 03:58
@dosubot dosubot bot added area/otel area/sampling changelog:new-feature Change that should be called out as new feature in CHANGELOG labels Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (13c715b) to head (2c03e7c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5718      +/-   ##
==========================================
- Coverage   96.89%   96.87%   -0.02%     
==========================================
  Files         334      334              
  Lines       16146    16146              
==========================================
- Hits        15644    15642       -2     
- Misses        333      334       +1     
- Partials      169      170       +1     
Flag Coverage Δ
badger_v1 8.06% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-6.x-v1 18.80% <ø> (+0.01%) ⬆️
elasticsearch-7.x-v1 18.86% <ø> (ø)
elasticsearch-8.x-v1 19.05% <ø> (ø)
elasticsearch-8.x-v2 1.90% <ø> (+0.01%) ⬆️
grpc_v1 9.45% <ø> (-0.02%) ⬇️
grpc_v2 7.39% <ø> (-0.02%) ⬇️
kafka 9.75% <ø> (ø)
opensearch-1.x-v1 18.90% <ø> (ø)
opensearch-2.x-v1 18.90% <ø> (ø)
opensearch-2.x-v2 1.90% <ø> (ø)
unittests 95.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yurishkuro yurishkuro merged commit 31e8ef9 into jaegertracing:main Jul 8, 2024
44 of 45 checks passed
@yurishkuro yurishkuro deleted the adaptive-sampling-e2e branch July 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/otel area/sampling changelog:new-feature Change that should be called out as new feature in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants