Rename storage/metricsstore To storage/metricstore

Signed-off-by: Mahad Zaryab <[email protected]>

.mockery.yaml

@@ -64,7 +64,7 @@ packages:
   github.com/jaegertracing/jaeger/storage/dependencystore:
     interfaces:
       Reader:
-  github.com/jaegertracing/jaeger/storage/metricsstore:
+  github.com/jaegertracing/jaeger/storage/metricstore:
     config:
       all: true
   github.com/jaegertracing/jaeger/storage/samplingstore:

cmd/jaeger/internal/extension/jaegerquery/server.go

@@ -20,7 +20,7 @@ import (
 	"github.com/jaegertracing/jaeger/pkg/telemetry"
 	"github.com/jaegertracing/jaeger/pkg/tenancy"
 	"github.com/jaegertracing/jaeger/plugin/metricstore/disabled"
-	"github.com/jaegertracing/jaeger/storage/metricsstore"
+	"github.com/jaegertracing/jaeger/storage/metricstore"
 )
 
 var (
@@ -138,7 +138,7 @@ func (s *server) addArchiveStorage(opts *querysvc.QueryServiceOptions, host comp
 	return nil
 }
 
-func (s *server) createMetricReader(host component.Host) (metricsstore.Reader, error) {
+func (s *server) createMetricReader(host component.Host) (metricstore.Reader, error) {
 	if s.config.Storage.Metrics == "" {
 		s.telset.Logger.Info("Metric storage not configured")
 		return disabled.NewMetricsReader()

cmd/jaeger/internal/extension/jaegerquery/server_test.go

@@ -31,8 +31,8 @@ import (
 	"github.com/jaegertracing/jaeger/storage"
 	"github.com/jaegertracing/jaeger/storage/dependencystore"
 	depsmocks "github.com/jaegertracing/jaeger/storage/dependencystore/mocks"
-	"github.com/jaegertracing/jaeger/storage/metricsstore"
-	metricsstoremocks "github.com/jaegertracing/jaeger/storage/metricsstore/mocks"
+	"github.com/jaegertracing/jaeger/storage/metricstore"
+	metricstoremocks "github.com/jaegertracing/jaeger/storage/metricstore/mocks"
 	"github.com/jaegertracing/jaeger/storage/spanstore"
 	spanstoremocks "github.com/jaegertracing/jaeger/storage/spanstore/mocks"
 )
@@ -81,11 +81,11 @@ func (fmf fakeMetricsFactory) Initialize(telemetry.Settings) error {
 	return nil
 }
 
-func (fmf fakeMetricsFactory) CreateMetricsReader() (metricsstore.Reader, error) {
+func (fmf fakeMetricsFactory) CreateMetricsReader() (metricstore.Reader, error) {
 	if fmf.name == "need-metrics-reader-error" {
 		return nil, errors.New("test-error")
 	}
-	return &metricsstoremocks.Reader{}, nil
+	return &metricstoremocks.Reader{}, nil
 }
 
 type fakeStorageExt struct{}

cmd/query/app/grpc_handler.go

@@ -19,7 +19,7 @@ import (
 	"github.com/jaegertracing/jaeger/plugin/metricstore/disabled"
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2"
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2/metrics"
-	"github.com/jaegertracing/jaeger/storage/metricsstore"
+	"github.com/jaegertracing/jaeger/storage/metricstore"
 	"github.com/jaegertracing/jaeger/storage/spanstore"
 )
 
@@ -242,7 +242,7 @@ func (g *GRPCHandler) GetLatencies(ctx context.Context, r *metrics.GetLatenciesR
 	if r.Quantile == 0 {
 		return nil, errMissingQuantile
 	}
-	queryParams := metricsstore.LatenciesQueryParameters{
+	queryParams := metricstore.LatenciesQueryParameters{
 		BaseQueryParameters: bqp,
 		Quantile:            r.Quantile,
 	}
@@ -259,7 +259,7 @@ func (g *GRPCHandler) GetCallRates(ctx context.Context, r *metrics.GetCallRatesR
 	if err := g.handleErr("failed to build parameters", err); err != nil {
 		return nil, err
 	}
-	queryParams := metricsstore.CallRateQueryParameters{
+	queryParams := metricstore.CallRateQueryParameters{
 		BaseQueryParameters: bqp,
 	}
 	m, err := g.metricsQueryService.GetCallRates(ctx, &queryParams)
@@ -275,7 +275,7 @@ func (g *GRPCHandler) GetErrorRates(ctx context.Context, r *metrics.GetErrorRate
 	if err := g.handleErr("failed to build parameters", err); err != nil {
 		return nil, err
 	}
-	queryParams := metricsstore.ErrorRateQueryParameters{
+	queryParams := metricstore.ErrorRateQueryParameters{
 		BaseQueryParameters: bqp,
 	}
 	m, err := g.metricsQueryService.GetErrorRates(ctx, &queryParams)
@@ -287,7 +287,7 @@ func (g *GRPCHandler) GetErrorRates(ctx context.Context, r *metrics.GetErrorRate
 
 // GetMinStepDuration is the gRPC handler to fetch the minimum step duration supported by the underlying metrics store.
 func (g *GRPCHandler) GetMinStepDuration(ctx context.Context, _ *metrics.GetMinStepDurationRequest) (*metrics.GetMinStepDurationResponse, error) {
-	minStep, err := g.metricsQueryService.GetMinStepDuration(ctx, &metricsstore.MinStepDurationQueryParameters{})
+	minStep, err := g.metricsQueryService.GetMinStepDuration(ctx, &metricstore.MinStepDurationQueryParameters{})
 	if err := g.handleErr("failed to fetch min step duration", err); err != nil {
 		return nil, err
 	}
@@ -312,7 +312,7 @@ func (g *GRPCHandler) handleErr(msg string, err error) error {
 	return status.Errorf(codes.Internal, "%s: %v", msg, err)
 }
 
-func (g *GRPCHandler) newBaseQueryParameters(r any) (bqp metricsstore.BaseQueryParameters, err error) {
+func (g *GRPCHandler) newBaseQueryParameters(r any) (bqp metricstore.BaseQueryParameters, err error) {
 	if r == nil {
 		return bqp, errNilRequest
 	}

cmd/query/app/grpc_handler_test.go

@@ -29,8 +29,8 @@ import (
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2"
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2/metrics"
 	depsmocks "github.com/jaegertracing/jaeger/storage/dependencystore/mocks"
-	"github.com/jaegertracing/jaeger/storage/metricsstore"
-	metricsmocks "github.com/jaegertracing/jaeger/storage/metricsstore/mocks"
+	"github.com/jaegertracing/jaeger/storage/metricstore"
+	metricsmocks "github.com/jaegertracing/jaeger/storage/metricstore/mocks"
 	"github.com/jaegertracing/jaeger/storage/spanstore"
 	spanstoremocks "github.com/jaegertracing/jaeger/storage/spanstore/mocks"
 )
@@ -599,21 +599,21 @@ func TestGetMetricsSuccessGRPC(t *testing.T) {
 		}{
 			{
 				mockMethod:    "GetLatencies",
-				mockParamType: "*metricsstore.LatenciesQueryParameters",
+				mockParamType: "*metricstore.LatenciesQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetLatencies(context.Background(), &metrics.GetLatenciesRequest{Quantile: 0.95, BaseRequest: baseQueryParam})
 				},
 			},
 			{
 				mockMethod:    "GetCallRates",
-				mockParamType: "*metricsstore.CallRateQueryParameters",
+				mockParamType: "*metricstore.CallRateQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetCallRates(context.Background(), &metrics.GetCallRatesRequest{BaseRequest: baseQueryParam})
 				},
 			},
 			{
 				mockMethod:    "GetErrorRates",
-				mockParamType: "*metricsstore.ErrorRateQueryParameters",
+				mockParamType: "*metricstore.ErrorRateQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetErrorRates(context.Background(), &metrics.GetErrorRatesRequest{BaseRequest: baseQueryParam})
 				},
@@ -681,8 +681,8 @@ func TestGetMetricsUseDefaultParamsGRPC(t *testing.T) {
 			BaseRequest: baseQueryParam,
 		}
 		expectedMetrics := &metrics.MetricFamily{Name: "foo"}
-		expectedParams := &metricsstore.CallRateQueryParameters{
-			BaseQueryParameters: metricsstore.BaseQueryParameters{
+		expectedParams := &metricstore.CallRateQueryParameters{
+			BaseQueryParameters: metricstore.BaseQueryParameters{
 				ServiceNames: []string{"foo"},
 				EndTime:      &now,
 				Lookback:     &defaultMetricsQueryLookbackDuration,
@@ -722,8 +722,8 @@ func TestGetMetricsOverrideDefaultParamsGRPC(t *testing.T) {
 			BaseRequest: baseQueryParam,
 		}
 		expectedMetrics := &metrics.MetricFamily{Name: "foo"}
-		expectedParams := &metricsstore.CallRateQueryParameters{
-			BaseQueryParameters: metricsstore.BaseQueryParameters{
+		expectedParams := &metricstore.CallRateQueryParameters{
+			BaseQueryParameters: metricstore.BaseQueryParameters{
 				ServiceNames: baseQueryParam.ServiceNames,
 				EndTime:      &endTime,
 				Lookback:     &lookback,
@@ -755,23 +755,23 @@ func TestGetMetricsFailureGRPC(t *testing.T) {
 		}{
 			{
 				mockMethod:    "GetLatencies",
-				mockParamType: "*metricsstore.LatenciesQueryParameters",
+				mockParamType: "*metricstore.LatenciesQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetLatencies(context.Background(), &metrics.GetLatenciesRequest{Quantile: 0.95, BaseRequest: baseQueryParam})
 				},
 				wantErr: "failed to fetch latencies: storage error",
 			},
 			{
 				mockMethod:    "GetCallRates",
-				mockParamType: "*metricsstore.CallRateQueryParameters",
+				mockParamType: "*metricstore.CallRateQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetCallRates(context.Background(), &metrics.GetCallRatesRequest{BaseRequest: baseQueryParam})
 				},
 				wantErr: "failed to fetch call rates: storage error",
 			},
 			{
 				mockMethod:    "GetErrorRates",
-				mockParamType: "*metricsstore.ErrorRateQueryParameters",
+				mockParamType: "*metricstore.ErrorRateQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetErrorRates(context.Background(), &metrics.GetErrorRatesRequest{BaseRequest: baseQueryParam})
 				},
@@ -796,7 +796,7 @@ func TestGetMetricsFailureGRPC(t *testing.T) {
 func TestGetMinStepDurationSuccessGRPC(t *testing.T) {
 	withServerAndClient(t, func(server *grpcServer, client *grpcClient) {
 		m := server.metricsQueryService.(*metricsmocks.Reader)
-		m.On("GetMinStepDuration", mock.AnythingOfType("*context.valueCtx"), mock.AnythingOfType("*metricsstore.MinStepDurationQueryParameters")).
+		m.On("GetMinStepDuration", mock.AnythingOfType("*context.valueCtx"), mock.AnythingOfType("*metricstore.MinStepDurationQueryParameters")).
 			Return(time.Hour, nil).Once()
 
 		res, err := client.GetMinStepDuration(context.Background(), &metrics.GetMinStepDurationRequest{})
@@ -808,7 +808,7 @@ func TestGetMinStepDurationSuccessGRPC(t *testing.T) {
 func TestGetMinStepDurationFailureGRPC(t *testing.T) {
 	withServerAndClient(t, func(server *grpcServer, client *grpcClient) {
 		m := server.metricsQueryService.(*metricsmocks.Reader)
-		m.On("GetMinStepDuration", mock.AnythingOfType("*context.valueCtx"), mock.AnythingOfType("*metricsstore.MinStepDurationQueryParameters")).
+		m.On("GetMinStepDuration", mock.AnythingOfType("*context.valueCtx"), mock.AnythingOfType("*metricstore.MinStepDurationQueryParameters")).
 			Return(time.Duration(0), errStorageGRPC).Once()
 
 		res, err := client.GetMinStepDuration(context.Background(), &metrics.GetMinStepDurationRequest{})
@@ -831,7 +831,7 @@ func TestGetMetricsInvalidParametersGRPC(t *testing.T) {
 			{
 				name:          "GetLatencies missing service names",
 				mockMethod:    "GetLatencies",
-				mockParamType: "*metricsstore.LatenciesQueryParameters",
+				mockParamType: "*metricstore.LatenciesQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetLatencies(context.Background(), &metrics.GetLatenciesRequest{Quantile: 0.95})
 				},
@@ -840,7 +840,7 @@ func TestGetMetricsInvalidParametersGRPC(t *testing.T) {
 			{
 				name:          "GetLatencies missing quantile",
 				mockMethod:    "GetLatencies",
-				mockParamType: "*metricsstore.LatenciesQueryParameters",
+				mockParamType: "*metricstore.LatenciesQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetLatencies(context.Background(), &metrics.GetLatenciesRequest{
 						BaseRequest: &metrics.MetricsQueryBaseRequest{
@@ -853,7 +853,7 @@ func TestGetMetricsInvalidParametersGRPC(t *testing.T) {
 			{
 				name:          "GetCallRates missing service names",
 				mockMethod:    "GetCallRates",
-				mockParamType: "*metricsstore.CallRateQueryParameters",
+				mockParamType: "*metricstore.CallRateQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetCallRates(context.Background(), &metrics.GetCallRatesRequest{}) // Test
 				},
@@ -862,7 +862,7 @@ func TestGetMetricsInvalidParametersGRPC(t *testing.T) {
 			{
 				name:          "GetErrorRates nil request",
 				mockMethod:    "GetErrorRates",
-				mockParamType: "*metricsstore.ErrorRateQueryParameters",
+				mockParamType: "*metricstore.ErrorRateQueryParameters",
 				testFn: func(client *grpcClient) (*metrics.GetMetricsResponse, error) {
 					return client.GetErrorRates(context.Background(), &metrics.GetErrorRatesRequest{})
 				},

cmd/query/app/http_handler.go

@@ -28,7 +28,7 @@ import (
 	"github.com/jaegertracing/jaeger/pkg/jtracer"
 	"github.com/jaegertracing/jaeger/plugin/metricstore/disabled"
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2/metrics"
-	"github.com/jaegertracing/jaeger/storage/metricsstore"
+	"github.com/jaegertracing/jaeger/storage/metricstore"
 	"github.com/jaegertracing/jaeger/storage/spanstore"
 )
 
@@ -306,32 +306,32 @@ func (aH *APIHandler) latencies(w http.ResponseWriter, r *http.Request) {
 		aH.handleError(w, newParseError(err, quantileParam), http.StatusBadRequest)
 		return
 	}
-	aH.metrics(w, r, func(ctx context.Context, baseParams metricsstore.BaseQueryParameters) (*metrics.MetricFamily, error) {
-		return aH.metricsQueryService.GetLatencies(ctx, &metricsstore.LatenciesQueryParameters{
+	aH.metrics(w, r, func(ctx context.Context, baseParams metricstore.BaseQueryParameters) (*metrics.MetricFamily, error) {
+		return aH.metricsQueryService.GetLatencies(ctx, &metricstore.LatenciesQueryParameters{
 			BaseQueryParameters: baseParams,
 			Quantile:            q,
 		})
 	})
 }
 
 func (aH *APIHandler) calls(w http.ResponseWriter, r *http.Request) {
-	aH.metrics(w, r, func(ctx context.Context, baseParams metricsstore.BaseQueryParameters) (*metrics.MetricFamily, error) {
-		return aH.metricsQueryService.GetCallRates(ctx, &metricsstore.CallRateQueryParameters{
+	aH.metrics(w, r, func(ctx context.Context, baseParams metricstore.BaseQueryParameters) (*metrics.MetricFamily, error) {
+		return aH.metricsQueryService.GetCallRates(ctx, &metricstore.CallRateQueryParameters{
 			BaseQueryParameters: baseParams,
 		})
 	})
 }
 
 func (aH *APIHandler) errors(w http.ResponseWriter, r *http.Request) {
-	aH.metrics(w, r, func(ctx context.Context, baseParams metricsstore.BaseQueryParameters) (*metrics.MetricFamily, error) {
-		return aH.metricsQueryService.GetErrorRates(ctx, &metricsstore.ErrorRateQueryParameters{
+	aH.metrics(w, r, func(ctx context.Context, baseParams metricstore.BaseQueryParameters) (*metrics.MetricFamily, error) {
+		return aH.metricsQueryService.GetErrorRates(ctx, &metricstore.ErrorRateQueryParameters{
 			BaseQueryParameters: baseParams,
 		})
 	})
 }
 
 func (aH *APIHandler) minStep(w http.ResponseWriter, r *http.Request) {
-	minStep, err := aH.metricsQueryService.GetMinStepDuration(r.Context(), &metricsstore.MinStepDurationQueryParameters{})
+	minStep, err := aH.metricsQueryService.GetMinStepDuration(r.Context(), &metricstore.MinStepDurationQueryParameters{})
 	if aH.handleError(w, err, http.StatusInternalServerError) {
 		return
 	}
@@ -342,7 +342,7 @@ func (aH *APIHandler) minStep(w http.ResponseWriter, r *http.Request) {
 	aH.writeJSON(w, r, &structuredRes)
 }
 
-func (aH *APIHandler) metrics(w http.ResponseWriter, r *http.Request, getMetrics func(context.Context, metricsstore.BaseQueryParameters) (*metrics.MetricFamily, error)) {
+func (aH *APIHandler) metrics(w http.ResponseWriter, r *http.Request, getMetrics func(context.Context, metricstore.BaseQueryParameters) (*metrics.MetricFamily, error)) {
 	requestParams, err := aH.queryParser.parseMetricsQueryParams(r)
 	if aH.handleError(w, err, http.StatusBadRequest) {
 		return

cmd/query/app/http_handler_test.go

@@ -39,7 +39,7 @@ import (
 	"github.com/jaegertracing/jaeger/plugin/metricstore/disabled"
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2/metrics"
 	depsmocks "github.com/jaegertracing/jaeger/storage/dependencystore/mocks"
-	metricsmocks "github.com/jaegertracing/jaeger/storage/metricsstore/mocks"
+	metricsmocks "github.com/jaegertracing/jaeger/storage/metricstore/mocks"
 	"github.com/jaegertracing/jaeger/storage/spanstore"
 	spanstoremocks "github.com/jaegertracing/jaeger/storage/spanstore/mocks"
 )
@@ -693,31 +693,31 @@ func TestGetMetricsSuccess(t *testing.T) {
 			name:                       "latencies",
 			urlPath:                    "/api/metrics/latencies?service=emailservice&quantile=0.95",
 			mockedQueryMethod:          "GetLatencies",
-			mockedQueryMethodParamType: "*metricsstore.LatenciesQueryParameters",
+			mockedQueryMethodParamType: "*metricstore.LatenciesQueryParameters",
 		},
 		{
 			name:                       "call rates",
 			urlPath:                    "/api/metrics/calls?service=emailservice",
 			mockedQueryMethod:          "GetCallRates",
-			mockedQueryMethodParamType: "*metricsstore.CallRateQueryParameters",
+			mockedQueryMethodParamType: "*metricstore.CallRateQueryParameters",
 		},
 		{
 			name:                       "error rates",
 			urlPath:                    "/api/metrics/errors?service=emailservice",
 			mockedQueryMethod:          "GetErrorRates",
-			mockedQueryMethodParamType: "*metricsstore.ErrorRateQueryParameters",
+			mockedQueryMethodParamType: "*metricstore.ErrorRateQueryParameters",
 		},
 		{
 			name:                       "error rates with pretty print",
 			urlPath:                    "/api/metrics/errors?service=emailservice&prettyPrint=true",
 			mockedQueryMethod:          "GetErrorRates",
-			mockedQueryMethodParamType: "*metricsstore.ErrorRateQueryParameters",
+			mockedQueryMethodParamType: "*metricstore.ErrorRateQueryParameters",
 		},
 		{
 			name:                       "error rates with spanKinds",
 			urlPath:                    "/api/metrics/errors?service=emailservice&spanKind=client",
 			mockedQueryMethod:          "GetErrorRates",
-			mockedQueryMethodParamType: "*metricsstore.ErrorRateQueryParameters",
+			mockedQueryMethodParamType: "*metricstore.ErrorRateQueryParameters",
 		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {
@@ -754,14 +754,14 @@ func TestMetricsReaderError(t *testing.T) {
 		{
 			urlPath:                    "/api/metrics/calls?service=emailservice",
 			mockedQueryMethod:          "GetCallRates",
-			mockedQueryMethodParamType: "*metricsstore.CallRateQueryParameters",
+			mockedQueryMethodParamType: "*metricstore.CallRateQueryParameters",
 			mockedResponse:             nil,
 			wantErrorMessage:           "error fetching call rates",
 		},
 		{
 			urlPath:                    "/api/metrics/minstep",
 			mockedQueryMethod:          "GetMinStepDuration",
-			mockedQueryMethodParamType: "*metricsstore.MinStepDurationQueryParameters",
+			mockedQueryMethodParamType: "*metricstore.MinStepDurationQueryParameters",
 			mockedResponse:             time.Duration(0),
 			wantErrorMessage:           "error fetching min step duration",
 		},
@@ -826,7 +826,7 @@ func TestGetMinStep(t *testing.T) {
 	metricsReader.On(
 		"GetMinStepDuration",
 		mock.AnythingOfType("*context.valueCtx"),
-		mock.AnythingOfType("*metricsstore.MinStepDurationQueryParameters"),
+		mock.AnythingOfType("*metricstore.MinStepDurationQueryParameters"),
 	).Return(5*time.Millisecond, nil).Once()
 
 	// Test

cmd/query/app/query_parser.go

@@ -15,7 +15,7 @@ import (
 
 	"github.com/jaegertracing/jaeger/model"
 	"github.com/jaegertracing/jaeger/proto-gen/api_v2/metrics"
-	"github.com/jaegertracing/jaeger/storage/metricsstore"
+	"github.com/jaegertracing/jaeger/storage/metricstore"
 	"github.com/jaegertracing/jaeger/storage/spanstore"
 )
 
@@ -232,7 +232,7 @@ func (p *queryParser) parseDependenciesQueryParams(r *http.Request) (dqp depende
 //	spanKinds ::= spanKind | spanKind '&' spanKinds
 //	spanKind ::= 'spanKind=' spanKindType
 //	spanKindType ::= "unspecified" | "internal" | "server" | "client" | "producer" | "consumer"
-func (p *queryParser) parseMetricsQueryParams(r *http.Request) (bqp metricsstore.BaseQueryParameters, err error) {
+func (p *queryParser) parseMetricsQueryParams(r *http.Request) (bqp metricstore.BaseQueryParameters, err error) {
 	query := r.URL.Query()
 	services, ok := query[serviceParam]
 	if !ok {