Split setColor params?

[sandeepmistry]

What do you think about changing the setColor param from a buffer to separate r, g, b values?

I can submit a PR from: sandeepmistry@40a2610

[jacobrosenthal]

I dont know that I have an opinion. I guess you could better explain which
is r g and b?

I just released 2.0.0 so If we did it id hold it up till the next api
breaker, or put it along side the existing and depreciate the old method
over the next release or two?

On Tue, Dec 23, 2014 at 7:50 PM, Sandeep Mistry [email protected]
wrote:

What do you think about changing the setColor param from a buffer to
separate r, g, b values?

I can submit a PR from: sandeepmistry/ble-bean@40a2610
sandeepmistry@40a2610

—
Reply to this email directly or view it on GitHub
#8.

[sandeepmistry]

It would reduce the overhead of creating a buffer to call the setColor API.

How about a setColorRGBor setRGBColor API, which in turn calls setColor with the r, g, b values converted to a buffer?

[jacobrosenthal]

sure

On Sun, Jan 4, 2015 at 8:26 AM, Sandeep Mistry [email protected]
wrote:

It would reduce the overhead of creating a buffer to call the setColor
API.

How about a setColorRGBor setRGBColor API, which in turn calls setColor
with the r, g, b values converted to a buffer?

—
Reply to this email directly or view it on GitHub
#8 (comment)
.