Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ack list is always increasing #7

Open
nsiitk opened this issue Oct 1, 2015 · 2 comments
Open

ack list is always increasing #7

nsiitk opened this issue Oct 1, 2015 · 2 comments

Comments

@nsiitk
Copy link
Contributor

nsiitk commented Oct 1, 2015

on receiving ack callback is retrieved from the ack[] but the list is always increasing. shouldn't executed cb be removed from ack[]. GCM spec says only 100 pending ack should be there in the ccs and this way can we manage the send message throttle

@nsiitk
Copy link
Contributor Author

nsiitk commented Oct 1, 2015

I have changed acks to hash {} and delete acks[msgid] on ack and nack. I can share the code but I am running it with node 12.7 is that ok

@jacobp100
Copy link
Owner

Should be fine! Send a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants