Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to the Python 3 version of jack #46

Closed
zzarne opened this issue Jan 19, 2022 · 6 comments
Closed

Default to the Python 3 version of jack #46

zzarne opened this issue Jan 19, 2022 · 6 comments

Comments

@zzarne
Copy link
Contributor

zzarne commented Jan 19, 2022

I want to discuss two issues here:

  1. Are we ready to default the Python 3 version?
  2. How do we do it?

I think we are ready, but maybe we want to fix #16 first.

I've never done this, but it should be as simple as

git checkout python3-mb
git checkout -b main
git push --set-upstream origin main

and then change the default branch in github Settings->Branches to main.

We then could rename the master branch to e.g. python2 to avoid confusion.

What do you say? Comments welcome.

@pimzand
Copy link
Contributor

pimzand commented Jan 19, 2022

I was going to propose the same, and ask the same.

Would clones be able to pull afterwards without issues, without any changes on their side?

@pimzand
Copy link
Contributor

pimzand commented Jan 19, 2022

Issue #16 is about a feature that isn't present in the current default version.
Users could keep using freedb/gnudb if it is that important to them.

@zzarne
Copy link
Contributor Author

zzarne commented Jan 20, 2022

Would clones be able to pull afterwards without issues, without any changes on their side?

As long as we don't rename the 'master' branch, existing clones would pull from the same branch as before. New clones would get the new default branch, which would be 'main', i.e. Python 3. So we won't rename the 'master' branch in the near future.

@madmartin
Copy link
Contributor

Maybe you can update the repository "About" description with hints about the meaning of the branches. I remember it took a while to figure out the python3 version is in a separate branch...

@pimzand
Copy link
Contributor

pimzand commented Feb 2, 2022

It appears the default can be set using the web interface:
https://github.com/jack-cli-cd-ripper/jack/settings/branches

@pimzand
Copy link
Contributor

pimzand commented Jun 12, 2022

Switched branches using the web interface. Closing.

@pimzand pimzand closed this as completed Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants