Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the level of PEP8 compliance #36

Open
madarche opened this issue Jul 12, 2020 · 2 comments
Open

Increase the level of PEP8 compliance #36

madarche opened this issue Jul 12, 2020 · 2 comments

Comments

@madarche
Copy link
Contributor

In the .travis.yml file, there are many exclusions of PEP8 conformance points: --ignore=E501,W604,W601,E721,E402,E711,E713,E741

Those exclusions have no reason apart from the lack of time when this repository was setup in GitHub.

Since the pep8 tool is at the moment the only safeguard, it would be better to use it to its full extent.

@pimzand
Copy link
Contributor

pimzand commented Jul 14, 2020

I suppose this is even worse for the python3-mb branch. I would be guilty of that.
Maybe we should revert 377bebc and c4cfd91 if possible

@zzarne
Copy link
Contributor

zzarne commented Jul 14, 2020

Reverting them would be of little help as most of the statements there were too long before those commits. Line continuation was ugly before, and I'm to blame mostly.
I think we should just fix what we have, little by little. And wherever possible make the code more readable.
This is a valid issue and we should keep it open until fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants