Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizability (contribution discussion) #16

Open
3DExtended opened this issue Mar 20, 2023 · 4 comments
Open

Add customizability (contribution discussion) #16

3DExtended opened this issue Mar 20, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@3DExtended
Copy link

Hey!

Thank you so much for this plugin! It works great.

I would like to contribute to this project and wanted to discuss your preferences first.
I want to replace the usage of VNDocumentCameraViewController because I think it is too limiting.

Are you willing to accept a PR which adds a dependency to another open source project? I found this project https://github.com/WeTransfer/WeScan which might be a good fit.

Another option is to implement the scanning with the Vision Kit ourselves.

What are your thoughts on this?
Let me know what you think and I might be able to help!

@jachzen
Copy link
Owner

jachzen commented Mar 30, 2023

I need to check wescan before. But Sure that may be a good idea as the Stock iOS Scanner ist very Limited.

@AkshayJainX
Copy link

@3DExtended, have you submitted the PR?

@vicajilau vicajilau added the enhancement New feature or request label Nov 12, 2023
@jachzen
Copy link
Owner

jachzen commented Mar 6, 2024

I think with CIDetector it may be working. I will do some testing and come up with a customimplementation.

@nhCoder
Copy link

nhCoder commented Mar 7, 2024

Yes, we need this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants