Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recurse option in config #235

Open
brandonaut opened this issue Dec 1, 2020 · 5 comments
Open

Add recurse option in config #235

brandonaut opened this issue Dec 1, 2020 · 5 comments

Comments

@brandonaut
Copy link

To avoid recursive clones when there are circular dependencies, gitman install --depth 1 can be used. However, this is risky as it requires the user to add it on every gitman install call. It would be nice to have a recurse field in gitman.yml to provide a little more control.

For example:

location: gitman_sources
sources:
  - name: mydep
    type: git
    repo: https://someurl.com/mydep.git
    recurse: false  # Don't process the gitman.yml in the mydep repo
    sparse_paths:
      -
    rev: master
    link:
    scripts:
      -
groups:
  -
@jacebrowning
Copy link
Owner

Do you have a use case for circular dependencies?

@brandonaut
Copy link
Author

My particular use case is for avoiding circular dependencies (which admittedly, is bad practice to begin with). However, I think the recurse field would be useful just as a way of controlling whether to pull another level of dependencies, whether they're circular or not.

As an aside: I suppose the ——depth CLI flag should override the recurse field, if they both are used.

@jacebrowning
Copy link
Owner

jacebrowning commented Dec 1, 2020

Yeah, I'm just trying to understand how common this situation is to warrant a feature to prevent it. 😄

@daniel-brosche
Copy link
Collaborator

I see some overlap to #128

@brandonaut
Copy link
Author

Good point @daniel-brosche. I think that resolve: flat would meet my need here. This issue can probably be closed in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants