Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read configuration from package.json instead of config.xml #83

Open
HarelM opened this issue Dec 31, 2019 · 3 comments
Open

Read configuration from package.json instead of config.xml #83

HarelM opened this issue Dec 31, 2019 · 3 comments

Comments

@HarelM
Copy link
Contributor

HarelM commented Dec 31, 2019

As of corodva 9.0 it seems that the configuration should be kept and read from package.json and not from config.xml.
Currently it seems that the plugin ignores package.json.
As an initial step support for both config.xml and package.json might be required.

@NiklasMerz
Copy link
Collaborator

Could you please provide info about this change with Cordova 9? I did not read about that, yet.

The build scripts are pretty complex and easy to break. I don't have the time to do this change. If you want to give it a try, I would happily review a PR.

@HarelM
Copy link
Contributor Author

HarelM commented Dec 31, 2019

https://cordova.apache.org/announcements/2019/03/18/cordova-lib-release-9.0.0.html
This in particular:
apache/cordova-lib#750
My config.xml file is almost empty expect plugins that have yet to migrate.
I'll read if there's a utility method cordova provides for this...

@HarelM
Copy link
Contributor Author

HarelM commented May 15, 2020

@BenjaminPoncet does your PR covers this? Can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants