Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove share ui and extra click #110

Open
HarelM opened this issue Nov 6, 2020 · 3 comments
Open

Remove share ui and extra click #110

HarelM opened this issue Nov 6, 2020 · 3 comments

Comments

@HarelM
Copy link
Contributor

HarelM commented Nov 6, 2020

I think it works be a better UX to simply remove the UI when sharing...
I can probably send a PR if this is something that can be of interest to this plugin...

@gatelli
Copy link

gatelli commented Jul 5, 2021

@HareIM do you have a fork with removed sharing UI ? 🙏

@HarelM
Copy link
Contributor Author

HarelM commented Jul 5, 2021

Due to complexity of signing this in iOS and the fact that my PR to ios cordova wasn't merged I have decided to find alternative solution to this issue.
I migrated out of this plugin and used intents for Android and openUrl for ios.
See here:
https://github.com/IsraelHikingMap/Site/blob/master/IsraelHiking.Web/src/application/services/open-with.service.ts

@gatelli
Copy link

gatelli commented Jul 6, 2021

Oh OK thanks !
Finally I could do it by applying this commit excepted the ShareExtension-Info.plist modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants