Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support docker_image #113

Merged
merged 4 commits into from
Nov 25, 2024
Merged

feat: support docker_image #113

merged 4 commits into from
Nov 25, 2024

Conversation

bxb100
Copy link
Contributor

@bxb100 bxb100 commented Nov 24, 2024

close: #50

@bxb100 bxb100 marked this pull request as ready for review November 24, 2024 04:48
@@ -212,6 +212,7 @@ impl LanguageImpl for Docker {
.args(&cmds[1..])
.args(hook_args.as_ref())
.args(batch)
.check(false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @j178 I set this because I think the user needs to know the container failed info

@j178
Copy link
Owner

j178 commented Nov 25, 2024

Thanks!

@j178 j178 merged commit b3619ba into j178:master Nov 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support docker_image language
2 participants