Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: dynamic run expensive test #99

Closed
wants to merge 1 commit into from
Closed

Conversation

bxb100
Copy link
Contributor

@bxb100 bxb100 commented Nov 22, 2024

close: #87


example: https://github.com/bxb100/pre-commit-rs/actions/workflows/ci-expensive.yml?query=branch%3ACI-demo2

test-branch: CI-demo CI-demo2

@j178
Copy link
Owner

j178 commented Nov 22, 2024

Thanks, gonna review soon!

@j178
Copy link
Owner

j178 commented Nov 23, 2024

This is a very clever approach. However, I'm hesitant to merge it right away, as our current Docker test isn't very costly and it's the only test that would benefit from this PR. I greatly appreciate your effort to improve this. In the future, if we have more expensive tests, I will definitely advocate for this change.

@bxb100
Copy link
Contributor Author

bxb100 commented Nov 24, 2024

ok

@bxb100 bxb100 closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamic run expensive CI
2 participants