feat: support init-templatedir #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j178
reviewed
Nov 22, 2024
src/cli/mod.rs
Outdated
| #[derive(Debug, Args)] | ||
| pub(crate) struct InitTemplateDirArgs { | ||
| /// The directory in which to write the hook script. | ||
| pub(crate) directory: String, |
There was a problem hiding this comment.
Suggested change
| pub(crate) directory: String, | |
| pub(crate) directory: PathBuf, |
j178
reviewed
Nov 22, 2024
src/cli/mod.rs
Outdated
| pub(crate) directory: String, | ||
|
|
||
| /// Assume cloned repos should have a `pre-commit` config. | ||
| #[arg(long, default_value_t = false)] |
There was a problem hiding this comment.
Suggested change
| #[arg(long, default_value_t = false)] | |
| #[arg(long)] |
j178
reviewed
Nov 22, 2024
src/cli/mod.rs
Outdated
Comment on lines
353
to
354
| #[arg(long, short = 't', default_value_t = HookType::PreCommit)] | ||
| pub(crate) hook_type: HookType, |
There was a problem hiding this comment.
Suggested change
| #[arg(long, short = 't', default_value_t = HookType::PreCommit)] | |
| pub(crate) hook_type: HookType, | |
| #[arg(short = 't', long = "hook-type", value_name = "HOOK_TYPE", value_enum)] | |
| pub(crate) hook_types: Vec<HookType>, |
|
Thanks! Could you add a test case too? |
Thanks for the review, will add it later. |
|
Should |
|
We don’t need to use mocks in integration tests. You can refer to other tests in the |
|
I made some tweaks and added a test, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #32