Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify example p38 #56

Closed
lesidaner opened this issue Jan 16, 2024 · 3 comments
Closed

modify example p38 #56

lesidaner opened this issue Jan 16, 2024 · 3 comments
Milestone

Comments

@lesidaner
Copy link

lesidaner commented Jan 16, 2024

on Link tag in the example

LINK type="location" href="http://ivoa.spectr/server?obsno="

but Link has no tribute type, should be content-role

Regards
Pierre

@tomdonaldson
Copy link
Contributor

It is recognized that Appendix A has a number of problems with its examples. The current plan (see #53) is to replace appendix A with an independent implementation note in version 1.6.

Since Appendix A begins with

The definitions enclosed in this appendix are not part of VOTable 1.1, but are considered as candidates for VOTable improvements.

perhaps no additional cautions are needed now for readers of this section.

@tomdonaldson
Copy link
Contributor

In looking more closely at this issue, I agree that LINK should not have an attribute type, but I'm less sure what makes this correct. From the descriptive text above it looks like the type="location" was supposed to be on the FIELD, but even that is explicitly not part of VOTable 1.5, just reserved for possible future use. I'm not sure if moving it there matches the original intent.

I would be happy to consider PRs to address this, but don't think it is worth much effort or discussion since the whole appendix is non-normative and slated for deletion.

@tomdonaldson
Copy link
Contributor

This was addressed with PR #62

@tomdonaldson tomdonaldson added this to the v1.5 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants