Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps to bundle the completion #83

Open
vkrizan opened this issue Nov 22, 2021 · 3 comments
Open

Steps to bundle the completion #83

vkrizan opened this issue Nov 22, 2021 · 3 comments

Comments

@vkrizan
Copy link
Contributor

vkrizan commented Nov 22, 2021

Hello,

The completion JS is bundled within the PyPi.
Would it be possible to share the steps how to bundle it?
We'd like to package it to RPM as well, to make it compatible.

Thank you.

@stebunovd
Copy link
Member

Hi @vkrizan,

I'm not familiar with RPM packaging, so please let me know if the steps described below are not what you're looking for. Basically, to install or upgrade the JS completion package I do the following:

  1. make sure that you have node installed and the latest version of Yarn v1 (also known as "yarn classic"). I'm currently using node v15. It may be compatible with other node versions, but I didn't check that;
  2. run yarn in the repo root to install JS dependencies mentioned in package.json, including djangoql-completion;
  3. run yarn build in the repo root to build the JS bundle using webpack. The resulting file is saved in djangoql/static/djangoql/js/ folder as specified in the Webpack configuration.

That's it. Does it work for you, or do you need anything else?

Thanks,

Denis

@vkrizan
Copy link
Contributor Author

vkrizan commented Nov 22, 2021

Thanks @stebunovd, that will do. Mostly we wanted to know how its build and what exactly is bundled where.

I'll look into it how to port it into the build process. There are some macros for Node.js build created. If you are curious you can check those out at https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/
Probably it could be an npm install kind of build, but I guess yarn is also available.

@stebunovd
Copy link
Member

I suppose npm should also work, there’s nothing yarn-specific in this build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants