Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling of eventualBG #203

Open
mountrcg opened this issue Dec 8, 2022 · 2 comments
Open

handling of eventualBG #203

mountrcg opened this issue Dec 8, 2022 · 2 comments

Comments

@mountrcg
Copy link
Contributor

mountrcg commented Dec 8, 2022

eventualBG from suggestion (rT in oref) receives a special treatment as there was a mistake in oref that did not convert eventualBG via oref function convert_bg(eventualBG,profile) into whatever user had chosen as BG unit. It was always handed over as an Integer in mg/dL. Fixing this in oref will issue errors in fax due to:

  1. @Published var eventualBG: Int?
  2. private func evetualBGStraing() -> String? {

I am easily able to fix 1 and 2, but not 3 and the resulting issues in

if let eventualBG = state.eventualBG {

@mountrcg
Copy link
Contributor Author

mountrcg commented Dec 8, 2022

there is also a typo in 3. as func is called evetualBGString instead of eventualBGString

@scrappy
Copy link

scrappy commented Nov 8, 2023

Just as an FYI, but this code base has been dead / unmaintained for over a year now ... this project was forked to, and renamed as, iAPS, where all current development is being done.

I heavily recommend to anyone still using FreeAPS X, migrate to the maintained code base, where features are being constantly added, and bugs are constantly being fixed.

High probabillity that the bug / issue reported above has long been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants